Repository navigation
[v3-3-test] Prevent React plugins from inheriting a prior bundle's component - #72136
Merged
Merged
Conversation
…che#71943) A React plugin bundle exports its component by assigning to the shared globalThis.AirflowPlugin as a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left there, so one plugin silently rendered another plugin's component instead of failing. Clear the shared global before each import so a bundle that assigns nothing surfaces a clear error rather than inheriting a stale component. (cherry picked from commit bdf3ee5)
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 27, 2026 08:38
Member
Author
|
Unrelated breeze doc ci failure |
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
) (#72136) A React plugin bundle exports its component by assigning to the shared globalThis.AirflowPlugin as a side effect of being imported. When a bundle is malformed or empty and never makes that assignment, the loader read whatever value a previously-loaded plugin had left there, so one plugin silently rendered another plugin's component instead of failing. Clear the shared global before each import so a bundle that assigns nothing surfaces a clear error rather than inheriting a stale component. (cherry picked from commit bdf3ee5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #71943 to
v3-3-test.Cherry-picked from bdf3ee5.
The source fix (
ReactPlugin.tsx) applied cleanly.ReactPlugin.test.tsxdid not exist onv3-3-test— it was introduced by #70149, which is not on this branch — so rather than pull in that PR's unrelated context-props tests, only this PR'sloadPluginregression test was carried over as a standalone file. Verified locally: it fails without the fix and passes with it.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines