Repository navigation
[v3-3-test] Reduce memory used when deleting queued asset events (#71917) - #71937
Merged
Merged
Conversation
) delete_asset_queued_events and delete_dag_asset_queued_event forced SQLAlchemy's "fetch" synchronize_session strategy on their AssetDagRunQueue deletes. That strategy reads the primary key of every deleted row back from the database to update the ORM session's identity map, but neither endpoint loads any AssetDagRunQueue objects into the session beforehand, so the read-back keys are matched against an empty map and discarded. The sibling delete_dag_asset_queued_events endpoint already used the default "auto" strategy; the other two now match it. (cherry picked from commit 49c5d51) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
1 task done
pierrejeambrun
marked this pull request as ready for review
August 21, 2026 14:50
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
August 21, 2026 14:50
pierrejeambrun
approved these changes
Aug 21, 2026
jason810496
approved these changes
Aug 22, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Sep 7, 2026
) (#71937) delete_asset_queued_events and delete_dag_asset_queued_event forced SQLAlchemy's "fetch" synchronize_session strategy on their AssetDagRunQueue deletes. That strategy reads the primary key of every deleted row back from the database to update the ORM session's identity map, but neither endpoint loads any AssetDagRunQueue objects into the session beforehand, so the read-back keys are matched against an empty map and discarded. The sibling delete_dag_asset_queued_events endpoint already used the default "auto" strategy; the other two now match it. (cherry picked from commit 49c5d51) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_asset_queued_events and delete_dag_asset_queued_event forced
SQLAlchemy's "fetch" synchronize_session strategy on their
AssetDagRunQueue deletes. That strategy reads the primary key of every
deleted row back from the database to update the ORM session's
identity map, but neither endpoint loads any AssetDagRunQueue objects
into the session beforehand, so the read-back keys are matched against
an empty map and discarded.
The sibling delete_dag_asset_queued_events endpoint already used the
default "auto" strategy; the other two now match it.
(cherry picked from commit 49c5d51)
Co-authored-by: Jyun-An Chen jun930436@gmail.com