Skip to content

docs: drop the private video link from Secret docs - #7027

Open
peda-cos wants to merge 1 commit into
anomalyco:devfrom
peda-cos:fix/secret-doc-video-link
Open

peda-cos wants to merge 1 commit into
anomalyco:devfrom
peda-cos:fix/secret-doc-video-link

Conversation

@peda-cos

Copy link
Copy Markdown

The 'Watch a video on how secrets work' link on https://sst.dev/docs/component/secret/ points to a private video (#6975).

Removes that <VideoAside> line from the Secret JSDoc in platform/src/components/secret.ts and the matching line in cmd/sst/main.go sst secret help text.

Reproduce: open https://www.youtube.com/watch?v=7tW2L3P6LKw (private page) and https://sst.dev/docs/component/secret/ (rendered player). Same change already merged in sst-community/sst#7.

@AlperSakarya

Copy link
Copy Markdown

@peda-cos there is already and issue and PR for it #6975

Also it's fixed in the community fork https://sst-community.github.io/sst/docs/component/secret/

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants