Repository navigation
fix: remove unreachable error check after https goroutine - #7007
Open
iliya-vidrush wants to merge 1 commit into
Open
iliya-vidrush wants to merge 1 commit into
iliya-vidrush wants to merge 1 commit into
Conversation
The err it tested was the os.Stat value the branch already proved nil; the go statement discards ListenAndServeTLS's error.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if err != nilblock aftergo http.ListenAndServeTLS(...)that could never run.errit tested belongs to the enclosingif _, err := os.Stat(keyPath); err == nil, so the branch only executes when it is nil, andgodiscards the TLS server's own error.return errinside was unreachable. HTTPS startup failures were already silent and still are.Validation
go build ./...andgo vet ./pkg/serverpass.