You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
tabs: tab label text and inkbar colors not aligned with spec #7685
Based on the spec, they show tabs on a white background having the indicator the same color as the text and primary color:
The current md-tabs shows the indicator as the accent color on a white background:
To make matters more complex, in the spec, the accent color is used when the theme background is non-white (or is the primary color)
I'm not sure if this can be easily fixed or if it will cause some theme inheritance problems. If so, perhaps md-tabs should be able to take md-theme ? Or does this just have to do with light theme vs. dark theme?
The spec does seem to contradict itself. I've seen in many google apps using the same primary color for both the indicator and the text, so long as the background is white/grey.
Either way, perhaps md-tabs can take the class md-primary and we can leave it up to the developer.
changed the title [-]tabs: default md-ink-bar color not aligned with spec[/-][+]tabs: tab label text and inkbar colors not aligned with spec[/+]on Sep 1, 2019
Activity
ddimitrop commentedon Mar 23, 2016
In fact reading the spec, it also shows an example where it states:
"Text color is the same as the tab indicator"
while in details below
Indicator:
"Height: 2dp"
"Color: #fff or accent color"
Tabs with text only
Text
14sp Roboto Medium
Active color: #fff or accent color
Unfocused tab color: #fff 70%
Reading this, it looks to me that the typical option is to use accent color for both the text and the indicator.
Do I read this incorrectly or is there an inconsistency?
topherfangio commentedon Mar 23, 2016
Definitely need to take a look and see if it still lines up with the spec. Perhaps something changed and we haven't updated styles accordingly.
ilovett commentedon Apr 12, 2016
The spec does seem to contradict itself. I've seen in many google apps using the same primary color for both the indicator and the text, so long as the background is white/grey.
Either way, perhaps
md-tabscan take the classmd-primaryand we can leave it up to the developer.10 remaining items
Splaktar commentedon Sep 1, 2019
Based on the tabs spec, there should be the following options for coloring
Currently
md-tabsuses the followingRan into this while looking at #11784.
[-]tabs: default md-ink-bar color not aligned with spec[/-][+]tabs: tab label text and inkbar colors not aligned with spec[/+]fix(toolbar): default to 500 hue and contrasts when using accent/warn…
Splaktar commentedon Jul 31, 2020
This should be resolved now, here are some screenshots:
Before
After
Here is the new

md-tabsdocumentation on theming:Splaktar commentedon Jul 31, 2020
And here are a bunch of tests that I did with primary/accent/warn palettes and light/dark modes:
md-primary
md-accent / md-warn
fix(tabs): align theming with spec updates