Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Autocomplete ng-messages wrong font-size #7477

Closed

Description

In master, ng-messages font size for autocomplete is wrong.

In codepen, you can compare input ng-message with autocomplete ng-message
http://codepen.io/anon/pen/ONNgMQ

Activity

  1. devversion commented on Mar 9, 2016

    @devversion
    Member

    Great demo, I'll take a look at this soon.

  2. added
    P1: urgentUrgent issues that should be addressed in the next minor or patch release.
    on Mar 17, 2016
  3. devversion commented on Mar 18, 2016

    @devversion
    Member

    Just investigated a bit and it seems to relate to the scope transclusion.

    I tried to create a scope transclusion myself to take a look at its most elegant solution.

    http://codepen.io/DevVersion/pen/WwRqaO?editors=1010

    So just want to notify you, that this issue is in progress.

  4. added
    needs: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
    on Mar 18, 2016
  5. EladBezalel commented on Mar 19, 2016

    @EladBezalel
    Member

    This is related to the styles applied,
    Take a look at input messages style

  6. devversion commented on Mar 20, 2016

    @devversion
    Member

    @EladBezalel Yes actually it is related to the styes. But updating the style selectors won't be the right solution, because the ngMessage isn't retrieving the animation class correctly.

    This is caused by the parent transclusion from the autocomplete.

    (https://github.com/angular/material/blob/master/src/components/input/input.js#L711)

  7. EladBezalel commented on Mar 20, 2016

    @EladBezalel
    Member

    👍

  8. modified the milestone: on Apr 20, 2016
  9. cairomassimo commented on Apr 26, 2016

    @cairomassimo

    I am not sure if this may helps:

    Pull request #5637 removed the code the replaces a wrapper div generated by mdAutocomplete. See this line:
    05d7f24#diff-f700fe0b273e851967e22440f2c464eeL25
    Also, see the occurences of the string md-autocomplete-replace in the whole repository. It was used as a marker class on the div to remove, but it is never taken into account.

    Since mdInputContainer requires ngMessages to be a direct child, this might be the cause of the problem.

  10. added 2 commits that reference this issue on May 9, 2016
    cc4b209
    befb1c4
  11. added
    has: Pull RequestA PR has been created to address this issue
    and removed
    needs: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
    on May 9, 2016
  12. added 2 commits that reference this issue on May 18, 2016
    f701272
    758ea6c
  13. removed this from the - Backlog milestone on Feb 23, 2019
  14. added a commit that references this issue on Sep 28, 2024
    06e7e99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1: urgentUrgent issues that should be addressed in the next minor or patch release.has: Pull RequestA PR has been created to address this issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions