Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

long pressing a link doesn't open the context menu on iOS #10622

Closed

Description

@ImaginationHub

Actual Behavior:

  • What is the issue? *
    In iOS 10, to touch and hold a link cannot bring up context menu, suppose it will bring up below context menu.
    http://oi63.tinypic.com/2hqf0uc.jpg

  • What is the expected behavior?
    Bring up context menu when hold on the link(which is html a tab)

CodePen (or steps to reproduce the issue): *

AngularJS Versions: *

  • AngularJS Version: v1.5.8
  • AngularJS Material Version: v1.1.1

Additional Information:

  • Browser Type: * Mobile Safari & Mobile Chrome
  • Browser Version: * 10.0
  • OS: * iOS 10.3.1
  • Stack Traces:

Activity

  1. self-assigned this
    on Dec 18, 2018
  2. added this to the 1.1.12 milestone on Dec 18, 2018
  3. added
    P3: importantImportant issues that really should be fixed when possible.
    needs: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
    on Dec 18, 2018
  4. changed the title [-]iOS Safari/Chrome - Touch and Hold on the link cannot bring up context menu[/-] [+]long pressing a link doesn't open the context menu[/+] on Dec 18, 2018
  5. changed the title [-]long pressing a link doesn't open the context menu[/-] [+]long pressing a link doesn't open the context menu on iOS[/+] on Dec 18, 2018
  6. Splaktar commented on Dec 18, 2018

    @Splaktar
    Contributor

    I can reproduce this with AngularJS Material 1.1.10 and HEAD (1.1.11) using iOS 12.1.1 on both Chrome and Safari using the docs. On another random web page, long pressing links does give a menu, but not on our docs.

  7. Splaktar commented on Dec 18, 2018

    @Splaktar
    Contributor

    This appears to be related to our use of https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout on the body. We apply -webkit-touch-callout: none;, but it's not clear why.

    I tracked this style back over 5+ years ago when the project first started and at no point could I find a reason that it was added. Based on this article it appears to be a recommended pattern for PhoneGap/Cordova/Ionic apps so that a "web" looking menu doesn't show up in your Hybrid app that is trying to fake like it's Native.

    For reference (from oldest to latest):

    Other related issues I found:
    handsontable/handsontable#5171

    Workaround:

    body {
      -webkit-touch-callout: default;
    }
  8. added
    needs: feedbackThe issue creator or community need to respond to questions in this issue
    and removed
    needs: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
    on Dec 18, 2018
  9. 20 remaining items

  10. added this to the 1.2.1 milestone on May 6, 2020
  11. removed
    needs: feedbackThe issue creator or community need to respond to questions in this issue
    on Sep 9, 2020
  12. Splaktar commented on Sep 9, 2020

    @Splaktar
    Contributor

    There has been no feedback on this in almost 2 years, so I think that it's plenty safe to change it to default.

  13. added a commit that references this issue on Sep 21, 2020
    77e3d53
  14. added a commit that references this issue on Sep 21, 2020
    3d98b6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3: importantImportant issues that really should be fixed when possible.has: Pull RequestA PR has been created to address this issueos: iOSThis issue is specific to iOSresolution: fixedtype: bugtype: ionicIssues specifically related to integration with the Ionic framework.ui: CSSux: integration

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions