Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

input: indentation different from the Material Design spec #10105

Closed
#11921
Closed
input: indentation different from the Material Design spec#10105
#11921
Assignees
Splaktar
Labels
- Breaking ChangeP3: importantImportant issues that really should be fixed when possible.has: Pull RequestA PR has been created to address this issueresolution: fixedtype: spec alignmentFor issues related to aligning with the Material Design Specui: CSS
Milestone
1.2.0

Description

@rvarbanov
rvarbanov
opened on Dec 7, 2016

Actual Behavior:

  • What is the issue? * Input indentation different from the official Material Design page.
  • What is the expected behavior?The Angular Material input have padding-left: 2px, but the Material Design page doesn't. If we are following the Material Design there the input label, input text, and input underline should be equally aligned to the left.

CodePen (or steps to reproduce the issue): *

Angular Versions: *

  • Angular Version: 1.5.9
  • Angular Material Version: 1.1.1

Additional Information:

  • Browser Type: * Google Chrome
  • Browser Version: * Version 55.0.2883.75 (64-bit)
  • OS: * macOS Sierra, 10.12.1
  • Stack Traces: n/a

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

Activity

  1. clshortfuse
    self-assigned this
    on Dec 7, 2016

  2. rvarbanov commented on Dec 9, 2016

    @rvarbanov
    rvarbanov
    on Dec 9, 2016
    Author

    @clshortfuse thoughts?

  3. clshortfuse
    assigned
    EladBezalel
    on Jan 23, 2017

  4. EladBezalel commented on May 8, 2017

    @EladBezalel
    EladBezalel
    on May 8, 2017
    Member

    @rvarbanov as this is true, this is a breaking change means it would only get in in 1.2.x in case we do it,
    and if we do - we need to make sure every other input (sidenav, autocomplete. etc..) is properly aligned as spec (which may vary over time)

    This would be nice to have but not that important right now imo :)

  5. EladBezalel
    added
    priority: low
    on May 8, 2017
  6. Splaktar
    added
    - Easy fix
    - needs: Pull Request
    P4: minorMinor issues. May not be fixed without community contributions.
    ui: CSS
    and removed
    priority: low
    on Nov 21, 2017
  7. Splaktar
    added this to the - Backlog milestone on Nov 21, 2017
  8. Splaktar
    added
    - Breaking Change
    on Mar 4, 2018
  9. Splaktar
    unassigned
    clshortfuse
    on Mar 4, 2018
  10. codymikol
    added a commit that references this issue on Aug 19, 2018

    fix(input): remove 2px left padding on inputs

    2adac4c
  11. Splaktar
    added
    has: Pull RequestA PR has been created to address this issue
    on Aug 29, 2018
  12. Splaktar
    unassigned
    EladBezalel
    on Aug 29, 2018
  13. Splaktar
    added
    type: spec alignmentFor issues related to aligning with the Material Design Spec
    and removed
    needs: Pull Request
    on Aug 29, 2018
  14. Splaktar
    changed the title [-]Input indentation different from the official Material Design page[/-] [+]input: indentation different from the Material Design spec[/+] on Aug 29, 2018
  15. Splaktar
    self-assigned this
    on Aug 29, 2018
  16. Splaktar
    modified the milestones: - Backlog, 1.2.0 on Aug 29, 2018
  17. Splaktar
    added
    P3: importantImportant issues that really should be fixed when possible.
    and removed
    P4: minorMinor issues. May not be fixed without community contributions.
    on May 28, 2020
  18. Splaktar
    added a commit that references this issue on May 28, 2020

    fix(input-container): align indentation with spec

    14a58a7
  19. Splaktar
    added a commit that references this issue on Jun 29, 2020

    fix(input-container): align indentation with spec

    1d93f7e
  20. Splaktar
    added
    resolution: fixed
    on Jun 29, 2020
  21. Splaktar
    closed this as completedin #11921on Jun 29, 2020
  22. Splaktar
    added a commit that references this issue on Jun 29, 2020

    fix(input-container): align indentation with spec

    31a596f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

- Breaking ChangeP3: importantImportant issues that really should be fixed when possible.has: Pull RequestA PR has been created to address this issueresolution: fixedtype: spec alignmentFor issues related to aligning with the Material Design Specui: CSS

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions