Repository navigation
Decode UTF-8 text from binary-mode streams in the Python loader - #461
Open
illusionoftalha wants to merge 1 commit into
Open
illusionoftalha wants to merge 1 commit into
illusionoftalha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #115.
Description of changes:
The pure-Python loader feeds text from a binary-mode stream to the byte-oriented text reader. Literal UTF-8 bytes are consequently interpreted as separate code points, corrupting symbols, strings, field names and annotations.
After the existing Ion binary-marker detection identifies text, wrap that stream in an incremental UTF-8 reader and select the Unicode text parser. The wrapper leaves ownership of the underlying stream with the caller. Ion binary data continues through the existing binary reader.
Add ten regression cases covering quoted symbols, short and long strings, struct field names and annotations, with both eager and iterative parsing. A catalog explicitly selects the pure-Python path even when the C extension is installed.
Validation on Windows / Python 3.12:
PYTHONPATH=src-python python -m pytest tests --ignore=tests/test_benchmark_cli.py --ignore=tests/test_benchmark_spec.py -q: 29,220 passed, 5 skipped. Test vectors were initialized from the pinned submodule revision.git diff --checkpasses.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.