Repository navigation
Conversation
Each master build now also tags the image as `<major>.<minor>` (for example `1.35` next to `1.35.9`). The minor tag always follows the newest patch image built for that minor version. Charts that derive the image tag from the cluster version break whenever a patch tag was skipped by the pipeline (alpine-docker#90, alpine-docker#96, alpine-docker#97). A minor tag lets them follow the cluster's major.minor instead. Closes alpine-docker#98. Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98.
Several issues (#90, #96, #97) came from charts that build the image tag from the cluster version. When the pipeline skips a patch release, for example because builds failed for a few weeks, that patch tag never exists and the pull fails. #98 asks for a tag that follows the minor version instead.
This PR adds one more
-tto thedocker buildx build --pushcall inbuild.sh:-t ${image}:${tag} \ + -t ${image}:${tag%.*} .So a master build of
1.35.9also pushes1.35. Each run only builds the newest patch of each minor version, so the minor tag always moves forward to the newest patch image. No new tool or registry call is needed. The README gets one paragraph about the new tag.What I checked: I ran
build.shwithdockerandsudoreplaced by stubs that only print their arguments (CIRCLE_BRANCH=master REBUILD=true, no build or push):None of
1.34,1.35,1.36or1.37exist on Docker Hub today, so nothing is overwritten. I did not run a real multi-arch build or push.Note: the minor tag only moves when a new patch image is built (or with
REBUILD=true), the same as the patch tags today.I used an AI assistant (Claude) to help find and draft this change. I reviewed it and ran the checks above myself.
🤖 Generated with Claude Code