Activity

1. sentinel-bot commented on Jul 17, 2019

   

   sentinel-bot

   on Jul 17, 2019

   Collaborator

   More actions

   Hi @Lovnx, we detect non-English characters in the issue. This comment is an auto translation from @sentinel-bot to help other users to understand this issue.
   We encourage you to describe your issue in English which is more friendly to other users.

   About rule persistence to apollo problem

   I used to use the sentinel-dashboard interface to manage the rules. The rules were persisted to apollo, but bugs were found during use, as described below:

   1. Modify the [current] flow control rule after opening the apollo environment.
      Before the update:
      
      
      Updated:
      
      
      

   2, [New] flow control rules, failed, and the [already] rules have been modified, not synchronized to apollo
   
   
   
   Modify the [already] rule failure error:
   `
   java.util.concurrent.ExecutionException: com.alibaba.csp.sentinel.dashboard.client.CommandFailedException: invalid type
   at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) ~[na:1.8.0_191]
   at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895) ~[na:1.8.0_191]
   at com.alibaba.csp.sentinel.dashboard.client.SentinelApiClient.setRules(SentinelApiClient.java:362) [classes/:na]
   at com.alibaba.csp.sentinel.dashboard.client.SentinelApiClient.setFlowRuleOfMachine(SentinelApiClient.java:482) [classes/:na]
   at com.alibaba.csp.sentinel.dashboard.controller.FlowControllerV1.publishRules(FlowControllerV1.java:272) [classes/:na]
   at com.alibaba.csp.sentinel.dashboard.controller.FlowControllerV1.updateIfNotNull(FlowControllerV1.java:242) [classes/:na]
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_191]
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_191]
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_191]
   at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_191]
   at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:209) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:102) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:891) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:797) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:991) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:925) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:974) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.servlet.FrameworkServlet.doPut(FrameworkServlet.java:888) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:664) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:851) [spring-webmvc-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at com.alibaba.csp.sentinel.adapter.servlet.CommonFilter.doFilter(CommonFilter.java:89) [classes/:na]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at com.alibaba.csp.sentinel.dashboard.filter.AuthFilter.doFilter(AuthFilter.java:110) [classes/:na]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:109) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:93) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:200) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-5.0.9.RELEASE.jar:5.0.9.RELEASE]
   at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:493) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:800) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:806) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1498) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_191]
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_191]
   at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-8.5.34.jar:8.5.34]
   at java.lang.Thread.run(Thread.java:748) [na:1.8.0_191]
   Caused by: com.alibaba.csp.sentinel.dashboard.client.CommandFailedException: invalid type

   2019-07-17 16:33:07.327 INFO 8644 --- [nio-8899-exec-6] c.a.c.s.d.controller.FlowControllerV1 : publish flow rules fail after rule update
   `
2. sentinel-bot

   changed the title [-]关于rule持久化到apollo问题[/-] [+]About rule persistence to apollo problem[/+] on Jul 17, 2019
3. sentinel-bot

   added

   kind/questionCategory issues related to questions or problemsCategory issues related to questions or problems

   on Jul 17, 2019
4. sczyh30

   added

   area/dashboardIssues or PRs about Sentinel DashboardIssues or PRs about Sentinel Dashboard

   on Jul 17, 2019
5. sczyh30 commented on Jul 17, 2019

   

   sczyh30

   on Jul 17, 2019

   Member

   More actions

   You might need to check whether the version of sentinel-transport-xxx matches sentinel-core in your application side.

   ---

   检查一下接入端 所有 Sentinel 相关依赖的版本 是否一致，是否有引入 Spring Cloud Alibaba dependencies 导致依赖版本被锁定。
6. Lovnx commented on Jul 18, 2019

   

   Lovnx

   on Jul 18, 2019

   Author

   More actions

   
   
   <dependency> <groupId>org.springframework.cloud</groupId> <artifactId>spring-cloud-starter-alibaba-sentinel</artifactId> <version>0.9.0.RELEASE</version> </dependency>

   是的，引入了这个包，相关sentinel依赖版本是1.5.2，目前sentinel-core都release了1.6.2了，为什么spring-cloud-starter-alibaba-sentinel还在0.9.0.RELEASE？？？
7. sczyh30 commented on Jul 18, 2019

   

   sczyh30

   on Jul 18, 2019

   Member

   More actions

   This might be related to the migration of Spring Cloud Alibaba: alibaba/spring-cloud-alibaba#761

   As a temporary solution, you could add all dependencies of Sentinel to <dependencyManagement> to lock the version to 1.6.2. See the FAQ.
8. sczyh30

   added

   integration/spring-cloudIssue related to Spring Cloud Alibaba integrationIssue related to Spring Cloud Alibaba integration

   on Jul 18, 2019
9. jasonjoo2010 commented on Jul 18, 2019

   

   jasonjoo2010

   on Jul 18, 2019

   Collaborator

   More actions

   For this issue you should refer to @fangjian0423

   SCA 0.9.1(developing) will upgrade it to the version 1.6.2.
   And if you want to change it you could try to add a property sentinel.version in you pom.xml to change the version manually. But please make sure that there is no compatibility problem.
10. Lovnx commented on Jul 18, 2019

    

    Lovnx

    on Jul 18, 2019

    Author

    More actions

    好的，那大概什么时候release SCA 0.9.1 ？？
11. sczyh30 commented on Jul 22, 2019

    

    sczyh30

    on Jul 22, 2019

    Member

    More actions

    I think it could be released in a few weeks :)
12. sczyh30

    closed this as completedon Jul 22, 2019
13. sczyh30

    changed the title [-]About rule persistence to apollo problem[/-] [+]Error when adding rules via the dashboard: CommandFailedException: invalid type[/+] on Aug 7, 2019
14. sentinel-bot

    added

    kind/bugCategory issues or prs related to bug.Category issues or prs related to bug.

    on Aug 7, 2019
15. sczyh30

    removed

    kind/bugCategory issues or prs related to bug.Category issues or prs related to bug.

    on Aug 7, 2019