You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
jap, it's a mess and my bad in part (like in re-doing the inputs for 2.3)... wanted to fix this myself in spare time but currently I dont have such thing^^
wow... yeah i can see that being a bit of an issue for usability....
sorry i've been absent on this project for a (long) while; I've been elsewhere and distracted etc etc.
From the screenshot it looks like a clash between the css hacks that were put in place (by me) to sort layout issues in the 2.2* releases against the nice new structured styles of the 2.3 releases. I doubt it's ExtJs causing that top-margin issue - take a look at the image+ stylesheets.
The clipping of the icon on the right hand side of the screenshot is definitely caused by the ExtJs framework - it uses explicit container widths for all panels and clips anything that overflows.
Has anyone got a fork of this fix on the go for 2.3 or do i need to brush the dust off my Modx?
sottwell you don't have to do that in the "doodles" tutorial. It's far more simpler. You fork this repo to your account. Then there is a _build as you can see in the repo. Just set it up in your webserver directory and run it. It will create the latest package. Now this puts everything in place already for you to work on the issues.(ofc you have to install the package) Once you create any changes on your local installation of the build you can just push those to your repo and propous the pull request to the original repo.
Activity
exside commentedon Dec 29, 2014
jap, it's a mess and my bad in part (like in re-doing the inputs for 2.3)... wanted to fix this myself in spare time but currently I dont have such thing^^
alanpich commentedon Dec 31, 2014
wow... yeah i can see that being a bit of an issue for usability....
sorry i've been absent on this project for a (long) while; I've been elsewhere and distracted etc etc.
From the screenshot it looks like a clash between the css hacks that were put in place (by me) to sort layout issues in the 2.2* releases against the nice new structured styles of the 2.3 releases. I doubt it's ExtJs causing that top-margin issue - take a look at the image+ stylesheets.
The clipping of the icon on the right hand side of the screenshot is definitely caused by the ExtJs framework - it uses explicit container widths for all panels and clips anything that overflows.
Has anyone got a fork of this fix on the go for 2.3 or do i need to brush the dust off my Modx?
yuka123 commentedon Jan 1, 2015
sottwell you don't have to do that in the "doodles" tutorial. It's far more simpler. You fork this repo to your account. Then there is a _build as you can see in the repo. Just set it up in your webserver directory and run it. It will create the latest package. Now this puts everything in place already for you to work on the issues.(ofc you have to install the package) Once you create any changes on your local installation of the build you can just push those to your repo and propous the pull request to the original repo.
Best, yuka
Jako commentedon Mar 25, 2015
Have done some compatibility work on the 2.2.0 version from MODX Extras and commited it to master on https://github.com/Jako/ImagePlus.
The folder renaming was somehow necessary to use GitPackageManagement for build. At that time I changed
tvimageplustoimageplusin the whole package.The main changes here:
Maybe they are also valid for 3.0.x branch.