Repository navigation
[feature required] does we can add the timeout or proxy parameters directly #711
Description
Like this, we will directly have the proxy and timeout parameters for the ClientSession, this will be very convenient in some situation.
class Client(aiohttp.ClientSession):
'''
based on aiohttp's ClientSession,and add:
- proxy proxy_auth (user,pass)
- timeout
'''
def __init__(self,timeout=None,proxy=None,proxy_auth=None,*args,**kwargs):
self.timeout = timeout
conn = None
if proxy:### handle proxy
if proxy_auth:
conn = aiohttp.ProxyConnector(proxy=proxy,proxy_auth=aiohttp.BasicAuth(proxy_auth[0], proxy_auth[1]))
else:
conn = aiohttp.ProxyConnector(proxy=proxy)
super().__init__(connector=conn,*args,**kwargs)
def _request(self,*args,**kwargs):
return asyncio.wait_for(super()._request(*args,**kwargs), self.timeout)
def _ws_connect(self,*args,**kwargs):
return asyncio.wait_for(super()._ws_connect(*args,**kwargs), self.timeout)
Activity
asvetlov commentedon Dec 28, 2015
Sorry, I've declined your feature request.
ClientSession(connector=ProxyConnector(proxy, proxy_auth=BasicAuth(login, password)).You still may use your own
Clientclass provided above in your code.timeoutparameter works only for connection establishment and sending request headers.It doesn't include time for sending request body and retrieving response back.
Most likely users need both.
The recommended way is using
Timeoutclass:a358003542 commentedon Dec 28, 2015
OK, listening and learned.
lock commentedon Oct 29, 2019
This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.
If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.