Repository navigation
Conversation
The import `from arc.experiment_git import ExperimentGitManager` references the pre-rename module path. The actual class lives in `researchclaw.experiment.git_manager`. Any call passing `git_repo_dir` to ExperimentRunner raises ModuleNotFoundError. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken/stale import in ExperimentRunner.__init__() so Git integration works again when git_repo_dir is provided (avoiding a ModuleNotFoundError due to a renamed module path).
Changes:
- Update the import of
ExperimentGitManagerfrom a non-existent legacy module path toresearchclaw.experiment.git_manager.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the fixes @sylearn, all three look correct and useful! One request: since these are all small, related fixes (stale import + resource management), could you consolidate PRs #96, #97, and #98 into a single PR? Something like "fix: stale import path and resource leak cleanups" would work. It reduces review overhead and keeps the git history cleaner. Appreciate the contributions! |
|
Consolidated into #102 as requested. |
Summary
ExperimentRunner.__init__()imports fromarc.experiment_git, which is a pre-rename module path that no longer existsresearchclaw.experiment.git_managergit_repo_dirraisesModuleNotFoundErrorOne-line fix: Update import to
researchclaw.experiment.git_manager.Test plan
researchclaw.experiment.git_manager.ExperimentGitManagerexistsarc.experiment_gitpath