Repository navigation
feat: expose Torch PD producer cache and chunk settings - #242
Draft
gspark-etri wants to merge 1 commit into
Draft
gspark-etri wants to merge 1 commit into
gspark-etri wants to merge 1 commit into
Conversation
This was referenced Oct 23, 2026
gspark-etri
added a commit
that referenced
this pull request
Oct 30, 2026
…214, #229, #241) (#281) - llmd: HTTP handler writes via MSG_NOSIGNAL so a client disconnect raises BrokenPipeError instead of hitting a vendor SIGPIPE handler (#215). - serve_batched: add the tokenizer EOS to generation_config EOS ids (#230); --pd-prefill-chunk / --pd-prefill-no-prefix-cache for the Torch producer (#242). - test that serve_stage's handler actually writes through the no-signal writer. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Torch PD serving always enabled producer prefix reuse and used chunk2048, independently of the decoder's cache/chunk settings. This prevented an uncached, matching-chunk comparison from the CLI. BF16 GPU PD showed concurrent differences on Qwen3-0.6B, KONI and Gemma; precision/cache/chunk controls under #240 isolate the tested conditions.
Changes
Expose
--pd-prefill-no-prefix-cacheand--pd-prefill-chunkfor the in-process Torch producer. Preserve cache-on/chunk2048 defaults and existing programmatic callers. Reject nonpositive chunks before loading the model. Document the independent producer/decoder policy.Verification
opt_prime/examples/pd/http_matrix/evidence241and the linked experiment record. No KV transport changes.Compatibility and limits
Stacked on #239. Explicit policy controls only; no default numerical or speedup promise. Disabling reuse and smaller chunks may cost performance. Vendor/subprocess producer configuration is unchanged. Original mismatches are retained under #240; broader numerical quality, performance and RNGD/GPU overlap remain separate work.
Related Issue
Closes #241; supports #240.