Repository navigation
feat(acp-core): add SessionInfoUpdate to the SessionUpdate union - #18
Open
ohulett-hub wants to merge 3 commits into
Open
ohulett-hub wants to merge 3 commits into
ohulett-hub wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
session_info_updateis a stable ACP v1SessionUpdatevariant (per the protocol schema), but acp-java-sdk'sSessionUpdateunion does not model it.Agents/clients that send or receive this notification fail with
InvalidTypeIdExceptioninstead of handling it as a normal typed update.This PR
SessionInfoUpdate(optionaltitle,updatedAt,_meta) as a registeredSessionUpdatesubtype, matching the protocol schema.WRITE_ONLYdiscriminator convention so each subtype still serializes itssessionUpdatekey exactly once.UserMessageChunknotification-handling test alongside new coverage for the rawsession_info_updatepayload.Validation
./mvnw clean verifypasses across all reactor modules (unit + integration).