Repository navigation
chore: Enable package.json exports support - #8294
Merged
Merged
Conversation
devongovett
marked this pull request as ready for review
May 23, 2025 01:00
snowystinger
approved these changes
May 23, 2025
reidbarber
approved these changes
May 23, 2025
|
hey, not sure this is ideal - we have a stricter tsconfig so the addition of 😅 edit: my bad! we have |
5 tasks done
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In collaboration with @snowystinger. Prerequisite for Storybook 8 and RSC support for new website.
This enables package.json exports support in Parcel, and TypeScript's
"moduleResolution": "bundler"mode. This makes our packages behave more like they do outside our repo. I added"source"fields to each export so that we can resolve without building the dist folders. And fallback"types"fields for source as well.This means we can no longer access sub-paths from packages that are not exported. To do that, you can use relative paths (but be careful to only do that in tests/stories/docs, and not in published code).