Fix Compat for React 19 types by snowystinger · Pull Request #6632 · adobe/react-spectrum

snowystinger · 2024-06-27T04:44:23Z

Closes

Found in Daniel's work, this adds needed compatibility between React 18 and 19 types. See microsoft/TypeScript#59049

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

rspbot · 2024-06-27T04:49:35Z

Build successful! 🎉

LFDanLu · 2024-06-28T20:16:13Z

Just a FYI, I pulled this into my load more branch locally for S2 development and verified that it fixed most of the lint issues except for this last numberfield one which I didn't look into yet:

src/NumberField.tsx(371,44): error TS2769: No overload matches this call.
[0]   The last overload gave the following error.
[0]     Argument of type '{ elementType: "div"; form?: string | undefined; formAction?: string | undefined; formEncType?: string | undefined; formMethod?: string | undefined; formNoValidate?: boolean | undefined; ... 32 more ...; style?: CSSProperties | ... 1 more ... | undefined; }' is not assignable to parameter of type 'AriaButtonOptions<ElementType>'.
[0]       Types of property 'onPress' are incompatible.
[0]         Type '((e: import("/Users/danilu/dev/experimental-s2/node_modules/react-aria-components/node_modules/@react-types/shared/src/events").PressEvent) => void) | undefined' is not assignable to type '((e: import("/Users/danilu/dev/experimental-s2/node_modules/@react-types/shared/src/events").PressEvent) => void) | undefined'.
[0]           Type '(e: import("/Users/danilu/dev/experimental-s2/node_modules/react-aria-components/node_modules/@react-types/shared/src/events").PressEvent) => void' is not assignable to type '(e: import("/Users/danilu/dev/experimental-s2/node_modules/@react-types/shared/src/events").PressEvent)

# Conflicts: # packages/@react-aria/virtualizer/src/Virtualizer.tsx # packages/react-aria-components/src/Collection.tsx # packages/react-aria-components/src/useDragAndDrop.tsx

rspbot · 2024-06-30T00:42:57Z

Build successful! 🎉

ktabors · 2024-07-11T16:32:27Z

 import {DraggableCollectionState} from '@react-stately/dnd';
 import {globalDndState, setDraggingCollectionRef} from './utils';
-import {RefObject} from 'react';
+import {} from 'react';


Why do we still need the react import here? I noticed in we dropped it in packages/@react-aria/grid/src/useGridRow.ts. There are additional places where we dropped it or did it this way too. It doesn't seem to be based on strict mode because there are some packages that have both versions.

# Conflicts: # packages/@react-aria/datepicker/src/useDateSegment.ts # packages/@react-aria/virtualizer/src/Virtualizer.tsx # packages/@react-types/shared/src/refs.d.ts # packages/react-aria-components/src/Collection.tsx # packages/react-aria-components/src/GridList.tsx # packages/react-aria-components/src/ListBox.tsx # packages/react-aria-components/src/Modal.tsx # packages/react-aria-components/src/Popover.tsx # packages/react-aria-components/src/Table.tsx # packages/react-aria-components/src/Tabs.tsx # packages/react-aria-components/src/Tooltip.tsx # packages/react-aria-components/src/Tree.tsx # packages/react-aria-components/src/utils.tsx

rspbot · 2024-07-12T00:50:52Z

Build successful! 🎉

rspbot · 2024-07-12T17:47:47Z

Build successful! 🎉

rspbot · 2024-07-12T18:35:17Z

Build successful! 🎉

rspbot · 2024-07-12T18:35:18Z

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

devongovett

Let's hope we can revert this eventually.

snowystinger added 2 commits June 27, 2024 10:43

Fix install

c03bd5c

Fix Compat for React 19 types

2983cd2

devongovett mentioned this pull request Jun 27, 2024

Generic parameter type checking stops too early microsoft/TypeScript#59049

Open

Base automatically changed from fix-install to main June 27, 2024 23:23

Merge branch 'main' into fix-our-react-19-types-for-compat

cc2ec34

# Conflicts: # packages/@react-aria/virtualizer/src/Virtualizer.tsx # packages/react-aria-components/src/Collection.tsx # packages/react-aria-components/src/useDragAndDrop.tsx

LFDanLu added the release label Jul 10, 2024

ktabors previously approved these changes Jul 11, 2024

View reviewed changes

snowystinger dismissed ktabors’s stale review via 2eb6405 July 12, 2024 00:33

ktabors previously approved these changes Jul 12, 2024

View reviewed changes

remove unneeded imports

d66d56f

LFDanLu dismissed ktabors’s stale review via d66d56f July 12, 2024 17:30

Merge branch 'main' into fix-our-react-19-types-for-compat

7adecb0

LFDanLu approved these changes Jul 12, 2024

View reviewed changes

devongovett approved these changes Jul 12, 2024

View reviewed changes

LFDanLu merged commit 63a2ff6 into main Jul 12, 2024

LFDanLu deleted the fix-our-react-19-types-for-compat branch July 12, 2024 21:59

dannify removed the release label Aug 13, 2024

devongovett mentioned this pull request Mar 4, 2025

React.js 19 nullable RefObject type is not supported #7549

Closed

Navigation Menu

Repository navigation

Fix Compat for React 19 types - #6632

Fix Compat for React 19 types#6632
LFDanLu merged 6 commits into
mainfrom
fix-our-react-19-types-for-compat

snowystinger commented Jun 27, 2024

Uh oh!

rspbot commented Jun 27, 2024

Uh oh!

LFDanLu commented Jun 28, 2024

Uh oh!

rspbot commented Jun 30, 2024

Uh oh!

ktabors Jul 11, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

devongovett left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

snowystinger commented Jun 27, 2024

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

Uh oh!

rspbot commented Jun 27, 2024

Uh oh!

LFDanLu commented Jun 28, 2024

Uh oh!

rspbot commented Jun 30, 2024

Uh oh!

ktabors Jul 11, 2024

Choose a reason for hiding this comment

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

rspbot commented Jul 12, 2024

Uh oh!

devongovett left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants