Add support for environment variables #14

Activity

1. adambrett commented on Mar 21, 2016

   

   adambrett

   on Mar 21, 2016

   Owner

   More actions

   @smalot I'm looking in to this, I don't really want to add a method for environment variables, at the moment I'm thinking of either a scoped command, or a scoped runner, something like this:

   $env = new Environment(new Exec(), $workingDir, $env);
   $env->run($command);

   or maybe

   $env = new Environment($workingDir, ['home' => '/home/abc/']);
   $shell = new Exec($env);
   $shell->run($command);

   or on the command instead:

   $command = new Command(...);
   $envCommand = new Environment($command, $workingDir, $env);
   $shell->run($envCommand);

   or...

   $command = new Command(...);
   $shell = new Exec();
   $env = new Environment($workingDir, $envVars);
   $shell->run($command, $env);

   Just ideas at the moment, not sure what direction to take it in...
2. smalot commented on Mar 21, 2016

   

   smalot

   on Mar 21, 2016

   Author

   More actions

   Sounds good !