feat(remove-stale-when-updated): Split remove-stale-when-updated option into remove-stale-when-updated and remove-stale-when-commented by francoiscampbell · Pull Request #390 · actions/stale

francoiscampbell · 2021-03-15T20:42:20Z

Currently, although updated PRs are not closed when updated, the stale label is not removed, even after re-running the action:

(redacted because this is not my PR)

~~This PR also removes the label when the PR is updated (for example by pushing a new commit).~~

This PR splits the options to remove the stale by renaming remove-stale-when-updated to remove-stale-when-commented and introducing a new meaning to remove-stale-when-updated, which is to remove the stale label when the stale issue is updated in other ways than comments (typically pushing a new commit).

This also happens to fix (what I think is) a bug that was reported to me today: if an issue has a stale label and then updated without comments, the stale timer isn't reset and the issue is still closed after days-before-close, not days-before-stale + days-before-close as expected.

C0ZEN · 2021-03-16T00:05:16Z

@francoiscampbell I saw this not long ago in the code #373 (comment)
I do not know if this is an issue or a choice but I think that at the end the action should have a new option to split which kind of trigger should remove the stale (comment or/and update).
And I would prefer to see a release containing this fix with the new option because if the bug is here since a long time people are used to it and basically changing the behaviour could result to unexpected un-stale.
What do you think?

francoiscampbell · 2021-03-16T15:49:59Z

Oh sure. I had originally assumed (we just started using this action yesterday) that the label was an indication of whether the PR was "eligible" for closing or not, and felt that if updating the PR delays the closing, it's not stale anymore and therefore the label should be removed.

It's unfortunate that the current name of the option is remove-stale-when-updated, since its behaviour is more like remove-stale-when-commented, and remove-stale-when-updated is what I would've used for this PR's use-case. Any suggestions for the name?

C0ZEN · 2021-03-16T22:29:07Z

I like the name of the options you propose. It makes sense and you can transform a bug into a fix with a new feature giving more control so I like that.

francoiscampbell · 2021-03-25T16:35:34Z

@C0ZEN Sounds good, I've gone and done the option split. Also updated the the PR title and description.

C0ZEN · 2021-03-25T20:25:20Z

Can you add the option in the readme?

…on into remote-stale-when-updated and remote-stale-when-commented

francoiscampbell · 2021-03-28T23:23:37Z

Ah oops, done.

francoiscampbell · 2021-04-12T19:57:31Z

@C0ZEN Do you think this is ready to merge?

C0ZEN

C0ZEN · 2021-04-28T22:02:34Z

@francoiscampbell conflicts FYI

pllim · 2021-06-02T21:29:42Z

 | `operations-per-run`          | Maximum number of operations per run.<br>GitHub API CRUD related.<br>_Defaults to **30**_.                                                     |
-| `remove-stale-when-updated`   | Remove stale label from issue/PR on updates or comments.<br>_Defaults to **true**_.                                                            |
+| `remove-stale-when-commented` | Remove stale label from issue/PR on comments.<br>_Defaults to **true**_.                                                                       |
+| `remove-stale-when-updated`   | Remove stale label from issue/PR on any update, including comments.<br>_Defaults to **true**_.                                                 |


Doesn't this make more sense? I can't tell if this is doc typo or intentional as I am not familiar with the code base.

Suggested change

| `remove-stale-when-updated` | Remove stale label from issue/PR on any update, including comments.<br>_Defaults to **true**_. |

| `remove-stale-when-updated` | Remove stale label from issue/PR on any update, excluding comments.<br>_Defaults to **true**_. |

T6751 · 2021-06-03T19:18:09Z

Can i fix these conflicts and open PR?
@C0ZEN
@francoiscampbell

C0ZEN · 2021-06-07T19:47:48Z

Since everyone is waiting for this I will do it.

Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity

Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false

* feat(options): add new options to avoid stale based on comments Helping to close #441, #470, #435? Closes #390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false * style(readme): fix table syntax due to rebase * docs(readme): add permissions only for the new options

Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false

francoiscampbell marked this pull request as ready for review March 15, 2021 22:10

francoiscampbell marked this pull request as draft March 25, 2021 16:13

francoiscampbell closed this Mar 25, 2021

francoiscampbell force-pushed the remove-label-on-update branch from 68cb3af to b717aa9 Compare March 25, 2021 16:29

francoiscampbell reopened this Mar 25, 2021

francoiscampbell changed the title ~~feat(remove-stale-when-updated): remove stale label when pr is updated~~ feat(remove-stale-when-updated): Split remote-stale-when-updated option into remote-stale-when-updated and remote-stale-when-commented Mar 25, 2021

francoiscampbell marked this pull request as ready for review March 25, 2021 16:34

feat(remove-stale-when-updated): split remote-stale-when-updated opti…

dccf347

…on into remote-stale-when-updated and remote-stale-when-commented

francoiscampbell force-pushed the remove-label-on-update branch from 51a7525 to dccf347 Compare March 28, 2021 23:22

C0ZEN approved these changes Apr 13, 2021

View reviewed changes

pllim mentioned this pull request May 20, 2021

Include option to ignore PR activity #435

Closed

C0ZEN mentioned this pull request May 26, 2021

Option to ignore new comments on stale issues #470

Closed

github-actions Bot added the Stale label May 29, 2021

pllim reviewed Jun 2, 2021

View reviewed changes

This was referenced Jun 2, 2021

Обновление стейлбота TauCetiStation/TauCetiClassic#7279

Merged

Stale label not being removed after new activity #441

Closed

github-actions Bot removed the Stale label Jun 4, 2021

C0ZEN added a commit to C0ZEN/stale that referenced this pull request Jun 7, 2021

feat(options): add new options to avoid stale based on comments

15580c1

Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity

C0ZEN mentioned this pull request Jun 7, 2021

feat(options): add new options to avoid stale base on comments #494

Merged

2 tasks done

luketomlinson closed this in #494 Jun 14, 2021

C0ZEN mentioned this pull request Jun 15, 2021

feat(options): add new options to avoid stale based on comments #508

Closed

2 tasks done

Navigation Menu

Repository navigation

feat(remove-stale-when-updated): Split remove-stale-when-updated option into remove-stale-when-updated and remove-stale-when-commented - #390

feat(remove-stale-when-updated): Split remove-stale-when-updated option into remove-stale-when-updated and remove-stale-when-commented#390
francoiscampbell wants to merge 1 commit into
actions:mainfrom
francoiscampbell:remove-label-on-update

francoiscampbell commented Mar 15, 2021 •

edited

Loading

Uh oh!

C0ZEN commented Mar 16, 2021

Uh oh!

francoiscampbell commented Mar 16, 2021

Uh oh!

C0ZEN commented Mar 16, 2021

Uh oh!

francoiscampbell commented Mar 25, 2021

Uh oh!

C0ZEN commented Mar 25, 2021

Uh oh!

francoiscampbell commented Mar 28, 2021

Uh oh!

francoiscampbell commented Apr 12, 2021

Uh oh!

C0ZEN left a comment

Uh oh!

C0ZEN commented Apr 28, 2021

Uh oh!

pllim Jun 2, 2021

Uh oh!

T6751 commented Jun 3, 2021

Uh oh!

C0ZEN commented Jun 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	\| `remove-stale-when-updated` \| Remove stale label from issue/PR on any update, including comments.<br>_Defaults to true_. \|
	\| `remove-stale-when-updated` \| Remove stale label from issue/PR on any update, excluding comments.<br>_Defaults to true_. \|

Conversation

francoiscampbell commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

C0ZEN commented Mar 16, 2021

Uh oh!

francoiscampbell commented Mar 16, 2021

Uh oh!

C0ZEN commented Mar 16, 2021

Uh oh!

francoiscampbell commented Mar 25, 2021

Uh oh!

C0ZEN commented Mar 25, 2021

Uh oh!

francoiscampbell commented Mar 28, 2021

Uh oh!

francoiscampbell commented Apr 12, 2021

Uh oh!

C0ZEN left a comment

Choose a reason for hiding this comment

Uh oh!

C0ZEN commented Apr 28, 2021

Uh oh!

pllim Jun 2, 2021

Choose a reason for hiding this comment

Uh oh!

T6751 commented Jun 3, 2021

Uh oh!

C0ZEN commented Jun 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

francoiscampbell commented Mar 15, 2021 •

edited

Loading