pages.example.com suffix declaration causes get_tld('example.com') == 'example.com' #18

Activity

1. jmehnle commented on Jul 15, 2020

   

   jmehnle

   on Jul 15, 2020

   Author

   More actions

   I tried to understand the _lookup_node method and fix the issue to create a PR, but haven't been successful in the limited time I have right now.
2. pombredanne commented on Jul 16, 2020

   

   pombredanne

   on Jul 16, 2020

   Last edited by pombredanne

   Member

   More actions

   @jmehnle Thanks for the report ! @hiratara @KnitCode what's your take on this case?
   Here the PSL has this entry:

   // Rochester Institute of Technology : http://www.rit.edu/
   // Submitted by Jennifer Herting <jchits@rit.edu>
   git-pages.rit.edu
   
3. jmehnle commented on Jul 16, 2020

   

   jmehnle

   on Jul 16, 2020

   Last edited by jmehnle

   Author

   More actions

   Just to be clear, this problem is more general than just the git-pages.rit.edu suffix. It will happen with any suffix (here: git-pages.rit.edu) that is an indirect subdomain of another suffix (here: edu): any intermediate domains (here: rit.edu) will erroneously be recognized as their own TLD when really that other suffix (here: edu) should be returned as the TLD instead.
4. hiratara commented on Jul 17, 2020

   

   hiratara

   on Jul 17, 2020

   Contributor

   More actions

   I think it's my fault. I made the same mistake with the rust library.

   rushmorem/publicsuffix#24

   $ python3
   Python 3.6.9 (default, Apr 18 2020, 01:56:04)
   [GCC 8.4.0] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> from publicsuffix2 import PublicSuffixList
   >>> psl = PublicSuffixList()
   >>> psl.get_tld("cdn.fbsbx.com")
   'fbsbx.com'    # WRONG
   

   psl.get_tld("git-pages.rit.edu")
   'git-pages.rit.edu' # WRONG, should be 'edu'

   I believe this behavior is correct. psl produces the same result.

   $ python3
   Python 3.6.9 (default, Apr 18 2020, 01:56:04)
   [GCC 8.4.0] on linux
   Type "help", "copyright", "credits" or "license" for more information.
   >>> import psl
   >>> psl.domain_suffixes("git-pages.rit.edu").public
   'git-pages.rit.edu'
   >>> psl.domain_suffixes("rit.edu").public
   'edu'
   >>> psl.domain_suffixes("edu").public
   'edu'
   >>> psl.domain_suffixes("cdn.fbsbx.com").public
   'com'
   
5. hiratara commented on Jul 18, 2020

   

   hiratara

   on Jul 18, 2020

   Contributor

   More actions

   We also have to consider with platform.sh problem .

   This ticket insists that the publicsuffix of rit.edu should be edu, and I am. So what should the publicsuffix of kobe.jp be? Our test insists that it should be "kobe.jp".

   Here is the result of psl:

   >>> psl.domain_suffixes("kobe.jp").public
   'jp'
   >>> psl.domain_suffixes("x.kobe.jp").public
   'x.kobe.jp'
   >>> psl.domain_suffixes("city.kobe.jp").public
   'kobe.jp'
   

   I think it's a good idea to make the same result as the psl.
6. hiratara commented on Jul 19, 2020

   

   hiratara

   on Jul 19, 2020

   Contributor

   More actions

   I`m trying to fix the issue with #19 .