Repository navigation
fix for calling completing read from emacsclient -e - #3086
Open
papercatlol wants to merge 1 commit into
Open
papercatlol wants to merge 1 commit into
papercatlol wants to merge 1 commit into
Conversation
Apparently 'emacsclient -e' doesn't set this-command, which makes ivy incorrectly copy some settings from ivy-last.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently
emacsclient -edoesn't setthis-command, which makesivy-readincorrectly copy some settings from ivy-last.In ivy-read: if both
callerandthis-commandare nil,callerstays nil, which then makesivy-alist-settingpull settings fromivy-last. This breaks things if previous ivy command was swiper or other ivy caller with special behavior.To reproduce:
emacsclient -c -e '(ivy-read "test: " (list "a" "b"))''ivy-readcaller in the proposed fix is just a placeholder and can be'unknown-caller,'defaultor whatever makes sense as a fallback value.