Repository navigation
iPhone 1.36.0 (build 56): database Tables fit a phone better - #87
Merged
Merged
Conversation
…fit a phone Core core-2.81.1-core.h4d33347386401068, built from ZenNotes/zennotes daedf423, the desktop 2.81.1 source. Four database fixes since 2.81.0: The Table row's hover Open no longer covers the end of a long name where nothing can hover (core's new zn-hover-only). The row's page icon, left of the name, still opens the page. The select column keeps its 40 px beside a long name (min-w-10). A Table with a long name opens at its first column: it used to scroll 40 px on opening when the first cell was wider than the pane, which hid the select column; it scrolls only when the cursor moves now. And the database header's tools wrap inside a narrow pane, so + Row and the ... menu stay on screen. No bridge contract, vault or navigation change came with it, so nothing here needs mirroring. table-touch.test.ts still pins 2.81.0's zn-hover-reveal on the row Open, so it goes red on this commit alone; the next commit removes the shell stopgap that core has replaced and repins it.
…s stopgap goes Shell commit 6f0721c hid the Table row's hover Open on a phone and held the select column at 40 px, because core 2.81.0 did neither. Core 2.81.1 does both: the overlay Open carries zn-hover-only, which is display none wherever nothing can hover, and the select column carries min-w-10. The hide rule no longer matched anything (it looked for zn-hover-reveal on that button) and the width rule said what core says, so both leave mobile.css. table-touch.test.ts pinned the old class in core, so it now pins what the shell relies on instead: zn-hover-only on the overlay Open, core's rule that hides it, the page glyph's own Open with no such class, and min-w-10 on the column's head and cells. read-open.ts keeps READ_PAGE_BUTTONS as it is. It matches the glyph, the one page button a finger can reach here, and the overlay it also matches never takes a tap with display none.
…s its place Walking core 2.81.1 on an iPhone 17 Pro (402 pt): core now wraps the database header's tools inside the pane, which is what keeps + Row and the ... menu on a narrower screen. On this one they miss a single line by 11 px (381 px of tools, 370 px of line), so the ... menu dropped alone to a third line of its own and pushed the Table down 34 px. Build 55 fit that width only by running past the header's padding, which is the overflow core just fixed. On a phone the shell now tightens the line instead of undoing core's wrap: 4 px between the tools and 8 px inside the four labelled buttons, 341 px in all. That holds one line on every width from 375 to 440 pt; at 360 and below the tools still wrap and stay on screen, as core intends. The ... button is a fixed square, so it keeps its size. Tests: core's wrapping class, the Button size this leans on, and the two declarations. Verified on the Release build by measuring the header with its width set to 440, 402, 393, 390, 375, 360 and 320; only the last two wrap. Filter, Columns, + Row and the ... menu all answer a tap at 402.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iPhone 1.36.0 (build 56), replacing build 55 while 1.36.0 is still Waiting for Review (Adib: "for ios you can probably replace the build, since it's not approved yet"). Core
core-2.81.1-core.h4d33347386401068(ZenNotes/zennotesdaedf423, desktop 2.81.1).table-touch.test.tsto core's real rules.Tests: 465 pass, 0 fail. Walked on a Release simulator build (iPhone 17 Pro, iOS 27.2): all four fixes hold; note, Tasks list and board, drawer and long-press menus are fine. Not run: the Cloud UI tests (Adib's), a physical device, the iPad layout.