Repository navigation
Android 1.1.54: Home names the open vault - #147
Merged
Merged
Conversation
Someone who keeps a work vault and a personal vault could not tell which one was open without opening the drawer, and the way to switch was hard to find (zennotesandroid#143). Home's header now shows the vault's name in a chip that opens the Vaults sheet. The drawer's header still does both, and a tablet keeps the sidebar's vault menu, so the chip is phone only. A long name truncates at 45% of the header, so the greeting stays on one line. The per-vault colors and icons the issue also suggests are not part of this. Also hides core's new way back to a hidden sidebar, data-sidebar-restore, since a phone layout has no sidebar to go back to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android 1.1.54 (versionCode 57) on core 2.82.0 (
core-2.82.0-core.h7fbea7b1c6714eb0, desktop tag v2.82.0).Walked on a throwaway Pixel 8 emulator (API 37, WebView 145) with real taps: onboarding, the vault chip with a long name and a vault switch, New Kanban with column colors and the Table chip, dark and light themes, the palette, Settings, a note edit, Tasks and Browse. Debug build. The tablet layout and remote vaults were not walked.