Repository navigation
Android 1.1.53: database Tables fit a phone better - #146
Merged
Merged
Conversation
…phone Core core-2.81.1-core.h4d33347386401068, built from ZenNotes/zennotes daedf423, desktop 2.81.1. Since 2.81.0 the packages change only in four database fixes and their What's new entry: on a touch screen a Table row's hover Open no longer covers a long name (the page glyph left of the name still opens the page); the select column keeps its 40 px; a Table with a long name opens at its first column, where it used to scroll 40 px on opening and hide the select column; and the header's tools wrap inside a narrow pane, so + Row and the ... menu stay on screen.
…h rules 1.1.52 hid the row's hover Open and held the select column at 40 px from mobile.css until core could do it (dca89c7). Core 2.81.1 does, with zn-hover-only and min-w-10, so the first rule matched nothing (core's button no longer carries zn-hover-reveal) and the second only repeated core. Both are gone, and users see no change. table-touch.test.ts pinned the old class in core. It now pins what the shell relies on: zn-hover-only on the overlay Open, core's rule hiding it where nothing can hover, the page glyph still in the row, and min-w-10 on both select cells. read-open.ts stays as it is. READ_PAGE_BUTTONS still matches the page glyph, the only Open a touch can reach, and the overlay where a mouse can hover it, which opens to read just the same.
Core 2.81.1 wraps the database header's tools inside the pane, which is what keeps + Row and the ... menu on a narrow screen. The tools need 375 px, so below about 407 CSS px a phone's line is just short of them and part of the row dropped to a line of its own, making the header taller than it has to be. The shell now tightens the line instead of undoing core's wrap, as iPhone 1.36.0 does: 4 px between the tools and 8 px inside the four labelled buttons, 341 px in all. The tools hold one line down to a 375 px screen; at 360 and below they still wrap and stay on screen, as core intends. The ... button is a fixed square, so it keeps its size. Tests: core's wrapping class, the Button size this leans on, and the two declarations.
The tighter header left the ... menu alone on a second line at 360 CSS px, the commonest Android width: the tools measured 334.4 px against a 328 px line, 6.4 px short. 6 px of padding inside the four labelled buttons instead of 8 px takes 16 px off, so all five hold one line there. At 320 they still wrap and stay on screen. Adib: "Yes, fix both".
…ng the database With a database's Filter or Columns open, system Back jumped to Home. The Back cascade closes menus, palettes, sheets and modals, but these are popovers (div[role="dialog"].z-popover), so Back fell through to navigation. 1.1.52's notes say Back closes menus and sheets, so this is a gap in that, found by the 1.1.53 walk. Back now closes a popover first, with an Escape from inside it. Core listens for it at the document, which an Escape sent to the window would never reach. A menu opened above a popover still goes first. Adib: "Yes, fix both".
adibhanna
force-pushed
the
release/1.1.53
branch
from
November 2, 2026 18:27
e54ea57 to
25fa02a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android 1.1.53 (versionCode 56), a patch on core
core-2.81.1-core.h4d33347386401068(ZenNotes/zennotesdaedf423, desktop 2.81.1). Adib: "for android, we can just create a new release".table-touch.test.tsto core's real rules.Tests: 495 pass, 0 fail. Walked on a throwaway AVD (Android 17, WebView 145, real taps, production web bundle on a debug build for CDP) at 411, 360 and 320 CSS px, plus 800 for tablet: all four fixes hold, and notes, Tasks list and board, drawer, long-press menus and system Back are fine. At 360 CSS px the tools take two lines, so the header is 167 px tall; nothing collides or clips.