Skip to content

[DF blackout window] timer to release a stuck blackout window. #1225

Open

Description

@ear-dev

We are seeing an occassional issue in Prod described here: #1158

Our logs do not show any failed HTTP requests, or anything at all, except that the visitor is in a blackout window. The CX logs are not showing anything either, so it is as if Rocketchat is not sending a response to the zeroTimerPayload, specifically in the 'boletoPause' case.

As a backstop, we should consider a timeout value for all blackout windows. If a response is not received from CX after 30 minutes (or some configured time) then release the blackout window. This will improve the user experience and and eventually allow the user to get unstuck.

Activity

  1. ear-dev commented on Jun 16, 2022

    @ear-dev
    Author

    Timer on HTTP timeouts, or after a configured timeout value.

  2. ear-dev commented on Jun 23, 2022

    @ear-dev
    Author

    NOTE: need to handle payloads from CX.agent that include 'continue_blackout'. continue_blackout resets the timer as well.

    timeout_value = 120seconds

  3. changed the title [-][DF blackout window] timer to release a stuck blackout window.[/-] [+][DF blackout window][Priority] timer to release a stuck blackout window.[/+] on Jun 23, 2022
  4. AlexanderKanakis commented on Jun 30, 2022

    @AlexanderKanakis
    Collaborator

    PRs:
    Apps.Dialogflow: WideChat/Apps.Dialogflow#160

  5. ear-dev commented on Jul 14, 2022

    @ear-dev
    Author

    @AlexanderKanakis @Shailesh351 we are seeing an issue where this feature works once, but fails a second time within the same session. We demo'd that at the meeting today.

    @Shailesh351 Can we look at the logs in kibana to try and understand the series of events please?

    Observation: In the case where the feature works the first time, we seem to be interfering with the original timer event from DF (180sec in our testbot test case) i.e. we never see that job get cancelled or executed. At this point we might be in a bad state.

  6. ear-dev commented on Jul 14, 2022

    @ear-dev
    Author

    @AlexanderKanakis please add a log point which includes the roomID to when your timeout event gets executed.

  7. ear-dev commented on Jul 14, 2022

    @ear-dev
    Author

    @AlexanderKanakis Since we already merged your drop queue branch into master, when you are making the fixes and adding the log point we discussed, please make a new branch and open a new PR. I think you may have pushed some fixes to the original feature branch you were working on? But instead of opening a new PR on that branch, it is better to have a new branch please. Thanks.

  8. AlexanderKanakis commented on Jul 18, 2022

    @AlexanderKanakis
    Collaborator

    New PR with fixes: WideChat/Apps.Dialogflow#162

  9. ear-dev commented on Aug 2, 2022

    @ear-dev
    Author

    NOTE: We rolled this fix back out of master. We are going to put this back in the backlog and address it later. @AlexanderKanakis when we decide to do it again you will need to port all changes to a new feature branch. Sorry for the confusion and extra work.

  10. changed the title [-][DF blackout window][Priority] timer to release a stuck blackout window.[/-] [+][DF blackout window] timer to release a stuck blackout window.[/+] on Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions