Repository navigation
Use :nth-child() to fix #365 - #367
Merged
Merged
Conversation
…irst todo item as completed The bug was caused by jQuery replacing the whole todo list whenever each todo item is toggled. Fixed it by running querySelectorAll in each iteration.
rniwa
approved these changes
Feb 3, 2024
rniwa
left a comment
rniwa
left a comment
Member
There was a problem hiding this comment.
Maybe this is better because it uses PageElement abstraction at least for 3.0 release?
flashdesignory
approved these changes
Feb 7, 2024
jrmuizel
pushed a commit
to mozilla/Speedometer
that referenced
this pull request
Jul 23, 2024
…eration (WebKit#367) This PR fixes the issue WebKit#365: jQuery test only ever marks the first todo item as completed The bug was caused by jQuery replacing the whole todo list whenever each todo item is toggled. Fixed it by running querySelector with :nth-child in each iteration. Co-authored-by: Ryosuke Niwa <rniwa@webkit.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #366 using a
:nth-childselector.Fixes #365