Skip to content

Add the ability to have async steps #83

Open

Description

@bgrins

There are some workloads that we hard to capture synchronously in a BenchmarkTestStep. Areas this has come up

  • Moanco (Two new editor workloads #81 (comment)) since it relies on a worker to do some processing
  • React-Stockcharts (Add react-stockcharts benchmarks #11 (comment)), and @camillobruni has raised some concerns with bimodal distribution on Chrome that is quite possibly related.
  • In the research on data grids I see some grid libraries that delay rendering and so spend 0ms during the step. I've also experimented with and think we should consider using in-memory SQLite WASM as a backend for these tests, and that runs in a worker so async is a must-have.
  • In the research on charting libraries that @julienw has been doing - where certain libraries delay rendering (especially React-based wrappers AIUI) in a way that causes significant work to happen outside of the timed window.

@rniwa and I discussed a bit on WebKit Slack, and concluded

yeah, making the sync step compatible with promise seems okay to me. We just need to make sure we don't accidentally start measuring truly async stuff like network loads and such.

I don't know mechanically what will be involved with a change here, and the main runner function comments about not using Promise

// This function ought be as simple as possible. Don't even use Promise.
. There's also #28 (comment) which may or may not make sense to tackle at the same time if we're going to be tweaking the core measurement function.

Activity

  1. bgrins commented on Mar 15, 2023

    @bgrins
    ContributorAuthor

    Status update: @camillobruni mentioned last meeting that was on his radar in the coming weeks

  2. rniwa commented on May 19, 2023

    @rniwa
    Member

    Sounds like we want to push this to v4 based on this week's sync?

  3. flashdesignory commented on Jan 29, 2025

    @flashdesignory
    Contributor

    @bgrins - can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions