Skip to content

[Feat] - Optimize Images, Update Admonitions - #141

Merged
alabulei1 merged 4 commits into
WasmEdge:mainfrom
adithyaakrishna:feat/update-main
Jul 27, 2023
Merged

alabulei1 merged 4 commits into
WasmEdge:mainfrom
adithyaakrishna:feat/update-main

Conversation

@adithyaakrishna

Copy link
Copy Markdown
Contributor

Description:

  • Added Info Admonitions for WIP
  • Updated Note Admonitions for Notes
  • Optimized Images to Save ~3mb

Adithya Krishna added 2 commits July 25, 2023 21:02
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>

alabulei1 commented Jul 25, 2023 •

Copy link
Copy Markdown
Collaborator

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

This GitHub pull request mainly focuses on updating and fixing documentation files. The changes involve updating various sections, fixing formatting issues, and adding important notes and code explanations. However, there are some potential issues and errors that need attention.

The commit message and author email are generic and not specific to the changes made, which can make it difficult to track and understand the purpose of the changes. Additionally, there are some formatting issues and unnecessary git diff code that should be removed from certain files.

One potential problem is the removal of the :::note admonition in kubedge.md and ssr.md files without explanation. It is necessary to confirm if this removal was intentional or accidental and check for any unintended consequences.

Another potential problem is the removal of content in the Work in Progress admonition in tensorflow.md and features.md files without explanation. It is important to verify if this removal was intentional or accidental and evaluate any unintentional consequences.

In terms of important findings, it is worth noting that lint issues were fixed in multiple files. However, the patch lacks specific details on the lint issues addressed, which would be helpful for a more comprehensive review.

Finally, the removal of the "WIP" label from the Rust plugin link in both the English and Chinese versions of features.md is a straightforward update with no identified potential problems.

Overall, while the changes primarily focus on documentation improvements, the potential issues with commit messages, formatting, and admonition removal require further clarification and confirmation.

Details

Commit c1d820cb9ad699727259a3b199b56d6c10b5c1c9

The key changes in this GitHub patch include:

  1. Updated various sections in the documentation files.
  2. Added a "Work in Progress" message in several files.
  3. Fixed a formatting issue in the Linux.md file.
  4. Added some important notes in the intro.md and kubedge.md files.
  5. Fixed a comment in the ssr.md file.
  6. Added a "Code explanation" section in the my_sql_driver.md file.

Potential problems to note:

  1. The commit message and author email seem to be generic and not specific to the changes made.
  2. Some files have formatting issues or unnecessary git diff code that should be removed.
  3. The "Work in Progress" message should be replaced with specific information about the ongoing work.

Overall, it seems that these changes mainly involve updating and fixing the documentation files. However, without further context or details on the specific changes made in each file, it is difficult to provide a more comprehensive review.

Commit 52475ae897f348ff41cc0de2520d7a4e56477580

Key changes:

  • Fixed lint issues in multiple files.

Potential problems:

  • The patch does not provide any details on the lint issues that were fixed. It would be helpful to have more information about the specific lint issues and how they were addressed.
  • The removal of the :::note admonition in kubedge.md and ssr.md files without any explanation may have unintentional consequences. It is necessary to verify if this removal was intentional or accidental.
  • The removal of the content in the Work in Progress admonition in tensorflow.md and features.md files without any explanation may have unintentional consequences. It is necessary to verify if this removal was intentional or accidental.

Commit 443b55b63b3d6f1416d3386407f8c0936f2660b2

Key changes:

  • Remove the "WIP" label from the Rust plugin link in the English version of features.md.
  • Remove the "WIP" label from the Rust plugin link in the Chinese version of features.md.

Potential problems:

  • No potential problems were identified in this patch.

Overall, the changes in this patch update the documentation by removing the "WIP" label from the Rust plugin link in both the English and Chinese versions of features.md.

Signed-off-by: Adithya Krishna <adikrish@redhat.com>
@alabulei1

Copy link
Copy Markdown
Collaborator

May I ask why we need _(Optional)_?

@adithyaakrishna

Copy link
Copy Markdown
Contributor Author

May I ask why we need _(Optional)_?

Basically, for optional fields or flags, it shows the optional in italics such that it will be clear to the user that it is an optional field and is different from the required fields/flags. To put it in a simpler words, it is to increase the readability of the docs

Signed-off-by: Adithya Krishna <adikrish@redhat.com>
@alabulei1
alabulei1 merged commit fcfa252 into WasmEdge:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants