Skip to content

refactor(table): default region overscroll-behavior to none - #270

Merged
F0rty-Tw0 merged 1 commit into
mainfrom
art/feat/aopt-overscroll-behaviour
Jul 8, 2026
Merged

F0rty-Tw0 merged 1 commit into
mainfrom
art/feat/aopt-overscroll-behaviour

Conversation

@F0rty-Tw0

Copy link
Copy Markdown
Collaborator

On touch devices, scrolling inside a table could chain to the page and bounce the whole viewport, causing missed taps. .table-region now defaults overscroll-behavior to none on both axes (was auto, y-only), mirroring the existing overflow token pattern. New -x and shorthand tokens let consumers override back to auto or contain.

Closes #263

- added support for `overscroll-behavior-x` in addition to `y`
- improved variable handling for overscroll behavior
@vercel

vercel Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
angular-advanced-table Ready Ready Preview, Comment Jul 8, 2026 1:12pm

@greptile-apps

greptile-apps Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge; the change is scoped to a CSS behavioral default for overscroll and introduces no logic regressions.

The new overscroll-behavior two-value shorthand mirrors the established overflow pattern exactly, the surface bridge variable for the x-axis was correctly added, and documentation is consistent. Consumers who previously relied on the implicit x-axis auto default can opt out via the new --nat-table-region-overscroll-behavior-x token.

No files require special attention; all four changed files are straightforward and consistent with existing patterns.

Important Files Changed

Filename Overview
libs/ng-advanced-table/src/table/table.css Core behavioral change: replaces overscroll-behavior-y longhand with the two-value shorthand, defaulting both axes to none; var() fallback chain mirrors the existing overflow pattern correctly.
libs/ng-advanced-table/components/feature/table-surface/table-surface.css Adds the --sys-nat-table-region-overscroll-behavior-x bridge variable to forward the new x-axis public token through the surface scope, completing the axis-specific bridge pair.
apps/showcase/public/docs/theming.md Documentation updated to list all three new overscroll-behavior tokens (shorthand, -x, -y) with their none defaults; consistent with the pre-existing pattern for overflow tokens in the same table.
apps/showcase/src/app/docs/docs-html-registry.ts Pre-rendered HTML for the docs page updated to match theming.md changes; appears to be generated output, no logic changes.

Reviews (1): Last reviewed commit: "refactor(table): ♻️ update overscroll be..." | Re-trigger Greptile

@F0rty-Tw0
F0rty-Tw0 requested a review from VaggelisKa July 8, 2026 13:18
@F0rty-Tw0
F0rty-Tw0 merged commit fc4f101 into main Jul 8, 2026
8 checks passed
@F0rty-Tw0
F0rty-Tw0 deleted the art/feat/aopt-overscroll-behaviour branch July 8, 2026 13:23

This branch was successfully deployed

1 active deployment
Preview — 1c881fdc Deployed Jul 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt overscroll-behavior none for better touch usability

1 participant