Repository navigation
refactor(table): default region overscroll-behavior to none - #270
Merged
Merged
Conversation
- added support for `overscroll-behavior-x` in addition to `y` - improved variable handling for overscroll behavior
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Confidence Score: 5/5Safe to merge; the change is scoped to a CSS behavioral default for overscroll and introduces no logic regressions. The new overscroll-behavior two-value shorthand mirrors the established overflow pattern exactly, the surface bridge variable for the x-axis was correctly added, and documentation is consistent. Consumers who previously relied on the implicit x-axis auto default can opt out via the new --nat-table-region-overscroll-behavior-x token. No files require special attention; all four changed files are straightforward and consistent with existing patterns.
|
| Filename | Overview |
|---|---|
| libs/ng-advanced-table/src/table/table.css | Core behavioral change: replaces overscroll-behavior-y longhand with the two-value shorthand, defaulting both axes to none; var() fallback chain mirrors the existing overflow pattern correctly. |
| libs/ng-advanced-table/components/feature/table-surface/table-surface.css | Adds the --sys-nat-table-region-overscroll-behavior-x bridge variable to forward the new x-axis public token through the surface scope, completing the axis-specific bridge pair. |
| apps/showcase/public/docs/theming.md | Documentation updated to list all three new overscroll-behavior tokens (shorthand, -x, -y) with their none defaults; consistent with the pre-existing pattern for overflow tokens in the same table. |
| apps/showcase/src/app/docs/docs-html-registry.ts | Pre-rendered HTML for the docs page updated to match theming.md changes; appears to be generated output, no logic changes. |
Reviews (1): Last reviewed commit: "refactor(table): ♻️ update overscroll be..." | Re-trigger Greptile
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On touch devices, scrolling inside a table could chain to the page and bounce the whole viewport, causing missed taps.
.table-regionnow defaultsoverscroll-behaviortononeon both axes (wasauto, y-only), mirroring the existing overflow token pattern. New-xand shorthand tokens let consumers override back toautoorcontain.Closes #263