Repository navigation
feat(theme): headless surface, opt-in stock theme - #257
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| libs/ng-advanced-table/components/feature/table-surface/table-surface.css | The surface bridge now forwards public tokens so the core table can inherit page styling by default. |
| libs/ng-advanced-table/components/theme.css | The new stylesheet defines the stock --nat-table-* token values for apps that opt in. |
| libs/ng-advanced-table/package.json | The package export map now exposes ng-advanced-table/components/theme.css. |
| libs/ng-advanced-table/ng-package.json | The theme stylesheet is included as an ng-packagr asset. |
Reviews (3): Last reviewed commit: "test(resizing): ✅ improve column resizin..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
F0rty-Tw0
force-pushed
the
art/feat/headless-unstyled-base
branch
from
July 7, 2026 14:38
a7095d4 to
5a7c965
Compare
- change `--showcase-page-bg` to `--sc-bg` in `docs` index HTML - clarify internal token usage in theming documentation
Updated the locator for the `Advancing` status chip in multiple features tests to select all matching elements instead of just the first one, ensuring accurate test behavior.
…ices - clarify the use of `--nat-table-*` custom properties - provide a canonical shape example for theme implementation - emphasize the importance of scoping themes on wrapper elements
- introduce a new CSS file for the stock theme - define CSS variables for colors, typography, spacing, and more - enhance the visual consistency of the table components fix(table-header-actions): 🐛 ensure background color fallback - update background property to include a transparent fallback - improve accessibility for sort icon chips fix(table): 🐛 adjust box-shadow for drag preview - refactor box-shadow to use a variable for drag preview shadow - maintain existing shadow styles as defaults
- change test description to clarify behavior with no tokens - ensure headless surface inherits ancestor text color
- replace direct assertions with polling for bounding width - enhance drag resize handle functionality with animation frame
F0rty-Tw0
force-pushed
the
art/feat/headless-unstyled-base
branch
from
July 8, 2026 09:16
5a7c965 to
674d06e
Compare
VaggelisKa
approved these changes
Jul 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
NatTableSurface's--sys-nat-table-*bridge tokens forward the public--nat-table-*tokens with no baked defaults, so an unthemed table inherits page/system colors instead of the dark-teal card look. Every component already carried its own neutral literal fallback, so nothing renders colorless.ng-advanced-table/components/theme.cssbrings back the old stock appearance. Import it once (global styles ormain.ts). It's wired as an ng-packagr asset plus a./components/theme.cssexport, verified resolvable after a real build.--nat-table-drag-preview-shadowtoken.theming.md,composition.md,quick-start.md) and thenat-best-practisesskill now describe the headless default and the opt-in import. Docs HTML registry regenerated.minorversion plan (no external consumers yet, so this ships without a major bump).Impact on existing code
theme.cssor provide--nat-table-*tokens.art/feat/css-discovery(docs: clarify nat table token overrides #253); merge that first.Closes #245