Repository navigation
feat(apps): offer reusable app-authoring checks - #2387
Open
JustYannicc wants to merge 1 commit into
Open
JustYannicc wants to merge 1 commit into
JustYannicc wants to merge 1 commit into
Conversation
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App authors often find unsupported patterns during a host build or review. Issue #2384 asks for checks they can run locally while keeping the exact framework pin they tested.
Change
The existing
appspackage exportsapps/checkandapps/oxlint. Theexecutor apps check --files <dir>command reports manifest and source-limit issues as JSON without host access.appConfig()loads the packaged Oxlint plugin by package specifier and enforces the authoring conventions. The Author an App guide documents the checks and their limits.Scope
This adds package exports and build entries, the CLI command, a changeset, docs, and one local CLI E2E. The work stays in the existing
appspackage. The CLI test uses the built package with repo-pinned Oxlint 1.83.0 and covers valid input plus rejected source and manifest cases.Verification
heavy-slot bun run apps:buildpassed.oxfmt --checkandgit diff --checkpassed.heavy-slot bun run e2e:local --test-name 'apps CLI prints the host.*app conventions'passed: 1 scenario.heavy-slot bun run e2e:checkrun emitted the repository's existing Effect warnings and no errors.e2e:preparestopped atpack-test-apps.ts: the localnpmwrapper mapsnpm packtopnpm pack, whose JSON shape the script does not accept. I packed the same builtappspackage withpnpm pack --json; the named E2E then passed.Model and harness: GPT-6 Luna in T3 Code through the Codex harness