Repository navigation
feat(policy): trust endpoint CAs and enable advisor proposals - #15
Merged
Merged
Conversation
Signed-off-by: craig <craig@kindo.ai>
Signed-off-by: craig <craig@kindo.ai>
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tls: skip/protocol: tcppolicies; TLS inspection and credential injection continue to apply.upstream_ca_pemin the policy advisor proposal API. CA proposals always require human review, and approval writes the CA into that sandbox's policy with hot reload.-placeholder in proposed rules, and point L4 denials atpolicy.localwhen proposals are enabled.Why
This is the fork companion needed by the two small mono policy PRs: Helm values overrides need endpoint CA trust, and user reviewed overrides need a working advisor and its CA proposal lane.
This PR does not add or remove VPN technology, remove the egress gateway, or change network mode wiring. It is a parallel path to existing fork PR #12 and covers the same functional lanes with fewer supplemental tests.
Verification
cargo fmt --all -- --checkpassed.localhostresolves through external DNS; TLS file watcher test: timeout in this sandbox). WritableTMPDIRandXDG_STATE_HOMEwere used.cargo clippyfor the six touched crates and all targets passed, with warnings in unchanged code and one non-Send generic warning in the fleet retry helper.mise run pre-commitreached license checking and failed on the existing missing SPDX header incrates/openshell-core/src/gateway_channels.rs. The new test file's header has been fixed.The CA lane and advisor fixes were previously k3d verified on their source branches.