Repository navigation
fix: lower CoreIpc send/receive logs from Information to Trace [ROBO-6001] - #155
eduard-dumitru wants to merge 1 commit into
Conversation
…6001] Connection/Server logged per request/response/message at Information, bypassing the LogEnabled gate the rest of CoreIpc respects (from #106). Any host that enables Info (e.g. the JsApi Handler) got flooded. Downgrade these diagnostics to Trace (off by default, so the flood stops for every host). Raise the receive-loop "Unknown message type" default arm to Error, ungated, so a protocol anomaly always surfaces. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bogdanStan92
left a comment
There was a problem hiding this comment.
Heads-up for the Robot bump — the description says Robot is unaffected either way, but this removes the escape hatch.
UIPATH_VERBOSE_IPC_LOGGING doesn't lower a level on the Robot side, it just skips registering the AddFilter rule in TraceUtilities.FilterIpcLogs. With no rule, MEL falls back to LoggerFilterOptions.MinLevel, which AddLogging() pins to Information — so Trace is dropped in Logger.IsEnabled, before the TraceSource → NLog sink. Verified on Robot develop: today these logs are visible with the env var set; after this PR they're unreachable in every configuration.
Concretely, three trace points used by the Robot performance CI (which is what sets that env var) stop matching: received request IStudioOperations RunJob, received request IAttendedService StartJob, sending response for IExecutorContract JobCompleted.
Nothing to change here — the fix is one line on the Robot side, it just has to land before/with the bump.
What
Connection/Serverlogged per request/response/message atInformation, bypassing theLogEnabledgate the rest of CoreIpc respects (introduced in #106). Any IPC host that enables Info — e.g. the JsApi Handler — gets flooded.Change
Information→Trace. Trace is off by default, so the flood stops for every host (Robot already filteredUiPath.Ipc.*below Error, so it's unaffected either way).defaultarm (Unknown message type): nowError, ungated — a protocol anomaly should always surface. AtErrorit also clears Robot'sUiPath.Ipc.*-below-Error log filter, so it's visible there now.Robot impact (when bumping UiPath.Ipc)
Unknown message typecan now appear (Error). That's intended, so it shows up in DiagTool reports.UIPATH_VERBOSE_IPC_LOGGINGset, the per-call lines (received request,sending response, send/receive steps,Create callback) disappear: Trace is below the Robot's Information minimum. In the bump PR:TraceUtilities.FilterIpcLogs, when the variable is set, also addbuilder.AddFilter("Ipc.", LogLevel.Trace).HostContext.UiPathIpcLogger's verbose path hands over the handler's logger, which also stops at Information; let Trace through there too.TracePoints_detailed.txt(perf CI,detailedTracePoints).RunJobReceived,StartJobReceivedandJobCompletedRespondingstop matching; the threeIpcClient calling/calledones already match nothing since the move off 2.1.0.Jira: ROBO-6001
🤖 Generated with Claude Code