Repository navigation
refactor: Improve error log message when manifest.json is empty - #1667
Merged
Merged
Conversation
RandomByte
reviewed
Oct 19, 2026
d3xter666
force-pushed
the
refactor-manifest-messages
branch
2 times, most recently
from
October 20, 2026 07:06
15d0eb5 to
2e094a7
Compare
Extend the parseJSON helper in project and builder packages to use try/catch around JSON.parse, distinguishing empty content (ERR_EMPTY_JSON) from malformed content (ERR_INVALID_JSON, thrown as SyntaxError). Update manifest readers in Application and Component to re-throw ERR_INVALID_JSON unwrapped, so the file path is preserved in the message shown to users instead of being hidden behind a generic "Failed to read" wrapper.
d3xter666
force-pushed
the
refactor-manifest-messages
branch
from
October 20, 2026 07:50
2e094a7 to
85ac842
Compare
RandomByte
approved these changes
Oct 20, 2026
RandomByte
requested changes
Oct 20, 2026
RandomByte
requested changes
Oct 20, 2026
d3xter666
force-pushed
the
refactor-manifest-messages
branch
from
October 21, 2026 05:05
e9b7e4e to
54980c9
Compare
d3xter666
force-pushed
the
refactor-manifest-messages
branch
from
October 21, 2026 05:23
54980c9 to
fca52ec
Compare
RandomByte
approved these changes
Oct 21, 2026
d3xter666
added a commit
that referenced
this pull request
Oct 22, 2026
JIRA: CPOUI5FOUNDATION-1046 This PR steps over and extends #1667. The reason behind this change is that besides it's not related to `manifest.json` parsing, it follows the same pattern for handling empty JSON files and providing more context in the error message. Thus, we handle this edge case of parsing empty JSON files the same. **Note:** There are special cases where an empty JSON is expected and is handled explicitly. Those are not touched. i.e. https://github.com/UI5/cli/blob/main/packages/builder/lib/processors/jsdoc/lib/createIndexFiles.js#L66-L68
d3xter666
added a commit
to SAP/ui5-builder
that referenced
this pull request
Oct 22, 2026
JIRA: CPOUI5FOUNDATION-1046 This PR steps over and extends UI5/cli#1667. The reason behind this change is that besides it's not related to manifest.json parsing, it follows the same pattern for handling empty JSON files and providing more context in the error message. Thus, we handle this edge case of parsing empty JSON files the same.
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-1046