Skip to content

refactor(identity): separate one-time token delivery from Application composition - #172

Merged
LIghtJUNction merged 3 commits into
fix/executor-core-20260929-2045from
fix/token-delivery-boundary-20260929
Sep 29, 2026
Merged

LIghtJUNction merged 3 commits into
fix/executor-core-20260929-2045from
fix/token-delivery-boundary-20260929

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

当前源码

Refs #162 #83 #85。当前head 26e43fc,tree ebe1facca432803854d0c04aaa93519a589ff93f,基于#167稳定头2d1cc443。3个原生生产文件与f015c60一致;最新提交只修新测试的真实事件读取并更新笔记。

进度:docs/TOKEN_DELIVERY_BOUNDARY_PROGRESS.md。最终云端检查尚未完成,不可依据旧头或父PR绿灯合并。

#162 实现

security.token_delivery.TokenDelivery独占现有token生成、恢复绑定、提交后一次领取/释放。Application只构造和兼容转发,HTTP/SSH执行器绑定同一release实例;Authentication共用同一recovery_verifier,不再复制公式。

仅显式传入metadata、既有token派生密钥、当前clock/window提供者;不传Root signer、vault、Registry、插件、HTTP或整棵Application。保留动态时钟/设置行为。

发行事务内登记恢复绑定;提交后才进入独立领取事务;领取提交后才将token加入响应。掉响应仍走原独立恢复操作,持久结果/Event/receipt不保存秘密。签署字节、操作版本、历史ID、期限和purpose不变,没有新协议或通用hook。

已下载并独立核验的云端证据

来源 head run / artifact JUnit
测试先行 b685262 36486490339 /10999622677 7 failed /115 passed /0 errors /0 skipped
首次实现 f015c60 36486854337 /10998634353 1 failed /121 passed /0 errors /0 skipped

SHA256分别0fed854c2890019a5892fbabdde7a6fe3093b05d6805b64d701504f9f44de958和0186be18b2ed3393af3fe5eaa5ee11eb1caa315f941cd0a1ddd469fb39fdc189;source.json匹配各自head/tree/run/attempt/Python3.15.0rc2。

红基线7个新增所有权用例准确失败,115个旧用例全部通过。首次实现唯一失败是新增测试误查不存在的events.request_id列;events实际存储seq/id/body,request_id在canonical Event JSON内。该用例此前的并发一次释放、回执、持久结果无秘密、恢复绑定断言均已通过。

最新提交按真实body JSON筛选,仍要求恰好一个事件,并增加subject一致、事件不含token/恢复秘密检查。不删断言,不为错误测试增加生产字段。必须在新头重跑同一完整选集。

合并门槛

凭据专项(新7例+旧115例)、完整四分片、精确node-ID全集/互斥gate、conformance/tokenizer、wheel/sdist及恢复/适用架构专项均需最终头通过。#167自身合并门槛独立,不向其稳定分支写入本次补丁来重启CI。

项目执行全部在云端,本地仅源码文本/AST/Git树检查与产物解析。#67原功能完成状态与所有旧安全回归保留。无生产部署、真实凭据/Root/PIN、资金/外发、备份销毁或恢复promotion。

… its protocol

Refs #162 #83 #85. Add independent-construction and real one-time-claim regressions before extracting the existing Application policy. Keep existing credential, client recovery, batch and security suites in the cloud gate.
… owner

Refs #162 #83 #85. Preserve issuance/claim transaction timing, legacy derivation and receipt bytes, expiry and one-time response semantics. Application only composes/delegates; authentication shares the exact verifier. Narrow current clock/window providers preserve live settings changes. All three native source blobs match the reviewed local text.
Copilot AI lite review requested due to automatic review settings September 28, 2026 21:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-28T21:37:40.751612Z f015c60 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

红基线已取得并独立核验,不再是pending:run36486490339,artifact10999622677,ZIP SHA256 0fed854c2890019a5892fbabdde7a6fe3093b05d6805b64d701504f9f44de958。source.json绑定测试先行头b68526267a4aaea2df8418ad4d400f64a845fa63、tree0f653206afd064f3e752cbb3442c202fbd72a4bb、attempt1、Python3.15.0rc2。

实际JUnit122项:7 failed /115 passed /0 errors /0 skipped。七个新增用例均在找不到独立token_delivery领域所有者处准确失败;全部115个原有凭据交付、恢复窗口、客户端和批处理安全用例通过。没有通过弱化断言制造基线。

修复头f015c60f05469f0058255bd645afef084e87840d保持不动:PR专项36486904671及完整36486904910等已触发;继承执行器36486904550/恢复36486904816报告success(这两份产物尚未独立下载)。最终凭据专项与完整门槛仍需核验,不把父PR #167四专项成功当成本头凭据验收。

…idence

Refs #162 #83. Correct the new test's nonexistent events.request_id column after independently verified cloud failure. Keep the exact one-event assertion and strengthen subject/secret checks against real stored Event JSON. Production code and schema are unchanged.
@LIghtJUNction
LIghtJUNction merged commit b0b5120 into fix/executor-core-20260929-2045 Sep 29, 2026
10 checks passed
LIghtJUNction added a commit that referenced this pull request Sep 29, 2026
Closes #162. Original #172 was merged only into an executor feature branch. Promotion head b0b5120 preserves that history and its six-file change.
Verified focused122 and full1901 exact-node-ID union, zero failures/errors/skips; conformance8, actual tokenizer, wheel/sdist and contracts gate pass. Full36551495771; focused36551495692. All four artifact hashes and source identity recorded in #175. No production deployment or broader acceptance closure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants