Repository navigation
fix(market): 结算事实必须绑定本订单托管账腿（#71 切片） - #151
Merged
Merged
Conversation
An authentic receipt reused from funding could make a still-held escrow look refunded; each settlement receipt must now be the exact refund or release leg debiting this order's escrow account. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
validate_projection只核对了order_settlements.receipts里的收据确实存在于money_ledger，没核对它们是不是本订单的托管账腿。这样一条伪造的退款事实（比如引用本单的入金收据，并同时改好可变投影 state/receipt_refs/settled_at）会被contract()当作已退款，而托管账户里的钱其实还没动。order_id一致、refund_minor/release_minor是非负整数，并且每张收据都要按顺序精确对应settle()产生的账腿（kind、从本单escrow_subject转出、收款方为买家或卖家、金额、币种、order_refund:/order_release:引用）。改动范围
src/msg/market/policy.py：validate_projection增加账腿绑定校验。tests/test_market_71.py：伪造「复用入金收据的退款事实」会被order_settlement_mismatch拒绝；真实超时退款仍能通过contract()，且守恒成立。测试计划
python -m pytest tests/test_market_71.py：4 passed（真实 PostgreSQL）。Refs #71（切片，不关闭）
Made with Cursor