Repository navigation
fix: bound incomplete path GET storage - #136
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GET /g/v1/chunk/...uploads from growing persistent SQLite storage unbounded and from indefinitely preventing TTL-based cleanup by replaying a single chunk.Description
path_max_transfersand expose it in the configuration, example config, rendered schema, and help text (src/msgd/config.py,deploy/etc/msg-lmm-best/msg.conf,src/msgd/render.py,src/msgd/server.py).SUM(LENGTH(data)) FROM path_get_chunksin_storage_bytes()and surfacepath_chunk_transfers/path_chunk_bytesin statistics (src/msgd/store.py).put_path_get_chunkwhile holding the store lock, returning appropriateStoreErrorconditions when limits are reached (src/msgd/store.py).createdonly when progress is made, and thread the newmax_storage_bytes/max_transfersparameters through the server chunk handler (src/msgd/store.py,src/msgd/server.py).tests/test_path_get.py).Testing
uv run ruff check .and it passed.uv run python -m unittest tests.test_path_get -vand observed all tests in that file pass (9 tests passed).uv run python -m unittest discover -s tests -vand observed147tests passed and1skipped (the skip is due to an unsetVALKEY_TEST_URL).git diff --checkand local status; no outstanding style or diff-check failures remained.Codex Task