Repository navigation
Bound purge tombstone retention - #135
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
purge_tombstonesrows with caller-controlled reasons without any retention or quota accounting, allowing delegated users to cause unbounded SQLite growth and potentially exhaust disk.Description
PURGE_TOMBSTONE_LIMIT = 10_000constant and an index on(purged_at, post_id)to support deterministic retention and efficient pruning insrc/msgd/store.py._prune_purge_tombstones()helper so upgrades reclaim existing excess rows._prune_purge_tombstones()after everypurge_postinsertion so repeated purge cycles cannot grow the table beyond the configured bound._prune_purge_tombstones()to delete all but the newestLIMITrows using a single SQLDELETE ... WHERE post_id NOT IN (SELECT post_id ... LIMIT ?)statement.test_purge_tombstones_have_bounded_retentionintests/test_msgd.pythat patches the limit to2, exercises repeated purge cycles, and asserts only the newest tombstones remain.Testing
uv run python -m unittest tests.test_msgd.ServerCase.test_purge_tombstones_have_bounded_retention tests.test_msgd.ServerCase.test_purge_can_irreversibly_remove_an_archived_post -vand both passed.uv run ruff check src/msgd/store.py tests/test_msgd.pywith no reported errors.uv run python -m unittest discover -s tests -vwhich completed successfully (147 tests passed, 1 skipped).git diff --checkand local diffs after changes (no check failures reported).Codex Task