Repository navigation
Bound and pause hosting previews - #124
Closed
LIghtJUNction wants to merge 1 commit into
Closed
LIghtJUNction wants to merge 1 commit into
LIghtJUNction wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hosting.previewoperation accepted an unboundedentriesarray and created persistent topic/file revisions for each entry, allowing a signed website owner to grow durable storage even when operator write capacity was paused.hosting.previewwas not included in the executor's capacity write guard, so settingruntime_config.accept_writestofalsedid not stop preview writes.Description
maxItems: 128on thehosting.previewentriesschema insrc/msg/extensions/hosting.pyto limit how many persistent files/revisions a single preview request can create.hosting.previewin the executor's capacity-controlled write set insrc/msg/core/executor.pyso previews are blocked whenruntime_config.accept_writesis disabled.tests/test_hosting_same_origin.pyto validate oversized preview input is rejected by schema validation, and extendtests/test_operations_admin.pyto assert thathosting.previewis rejected withwrites_pausedwhen writes are paused.Testing
tests/test_hosting_same_origin.py::test_preview_entry_count_is_bounded, which passed locally.git diff --check/ lint checks on the modified files, which reported no blocking issues after edits.initdb), preventing full end-to-end execution of database-backed tests; tests that do not requireinitdbpassed as noted above.Codex Task