Repository navigation
fix(sidebar): give compact host rows the full name line - #2
Merged
Merged
Conversation
Compact rows put the name, tags, address and actions on one line, so names were cut to a few characters. The name now has its own line with the pin and lock markers; actions, address and tags that fit go on a second line, and the tooltip always lists the address and all tags.
|
AI review | Looks safe to merge Refactors compact host rows into a fixed 48px two-line layout and simplifies virtualizer height estimates. Follows plugin rules, uses i18n correctly, and includes comprehensive tests. Reviewed 677fb64. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In compact density the host row squeezed the name and the status/address line into one short row, so long names were cut early and the hover actions covered the name. Compact host rows now get the full name line and a second line for details (row height 48 px,
COMPACT_HOST_ROW_HEIGHT), and the virtualizer uses the same height. Comfortable density is unchanged (screenshot is byte-identical).Files:
HostItem.tsx,SidebarTree.tsx, testsHostItem.test.tsx,sidebar-density.test.tsx.Screenshots (before → after)
Verification
npm test: 64 files, 398 tests pass.npm run typecheck,npx prettier --check .,npx termix-plugin validate,npm run build: pass.npx termix-plugin testsometimes exits 1 withEnvironmentTeardownError("Closing rpc while onUserConsoleLog was pending") fromtests/frontend/layout/classic-layout.test.tsx. This also happens on unchangedmain, so it isn't caused by this change.