Repository navigation
non-reference pattern used to match a reference (see issue #42640) #115
Description
Hi!
On grabbing 0.2.9 from crates.io last night, I hit the following error several times as it tries to compile structopt-derive:
error[E0658]: non-reference pattern used to match a reference (see issue #42640)
--> C:...\structopt-derive-0.2.9\src\attrs.rs:112:17
|
112 | / NameValue(MetaNameValue {
113 | | ident,
114 | | lit: Str(value),
115 | | ..
116 | | }) => self.push_str_method(&ident.to_string(), &value.value()),
| |__________________^
help: consider using a reference
Known issue?
Activity
TeXitoi commentedon Jun 6, 2018
Looks like a direct deps of rust 1.26
TeXitoi commentedon Jun 6, 2018
what's your rust version? Is updating to latest stable fix this problem?
hcpl commentedon Jun 6, 2018
@zigguratvertigo the code you pointed to uses default binding modes, implemented a while ago and stabilized in Rust 1.26.
On the related note, I'd like to know what is the policy around minimum supported Rust version for
structopt.claphas the policy written down in this issue: clap-rs/clap#740 and it is enforced using Travis CI. @TeXitoi thoughts?TeXitoi commentedon Jun 6, 2018
No policy for the moment, but it can be added. I think at minimum, we should add a specific version in .travis.yml to catch the needed rust upgrades.
TeXitoi commentedon Jun 6, 2018
Maybe "must compile if latest clap compiles" a good policy?
hcpl commentedon Jun 6, 2018
This sounds reasonable to me. The latest
claptracks 1.21 which should cover enough users targeting CLI apps.I also suggest placing a short note about required Rust version in README and/or other easily visible places.
zigguratvertigo commentedon Jun 6, 2018
@TeXitoi updating to latest 1.56.2 fixed the compilation issue - thanks.
Having a check around the minimum supported rust version would be great.
Add a minimum rustc version policy (#116)