Repository navigation
perf: defer validate and review imports in maintainer command - #345
Conversation
🦋 Changeset detectedLatest commit: d54c07e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d54c07e
☁️ Nx Cloud last updated this comment at |
commit: |
Merging this PR will not alter performance
|
🎯 Changes
maintainer.tsstatically importedrunReviewCommand(./review.js),runValidateCommand(./validate.js), anddescribeSkillExamples(../validate/blocks.js), which loaded the validation, example-checking, and review command chunks on everyintent maintainerinvocation (setup,add,remove,sync,status --json) and caused Rolldown to emit a duplicatedist/review-*.mjs(0.09 kB) facade chunk../review.jsto theaction === 'review'branch,./validate.jstoaction === 'check', and../validate/blocks.jsto non-JSONaction === 'status'.dist/review-*.mjsfacade chunk and keepsvalidate-*.mjs,blocks-*.mjs,review-*.mjs, andworkflow-review-*.mjs(~78 kBcombined) off the startup path ofmaintainer setup,add,remove,sync, andstatus --json.benchmarks/intent/maintainer.bench.ts, Vitest 4.1.11 on Windows Node)main(cb45f14) mean (min / rme)d54c07e) mean (min / rme)maintainer setup with 20 existing skills✅ Checklist
pnpm run test:pr(runpnpm build:allfirst).🚀 Release Impact