Repository navigation
perf: skip redundant filesystem probes during discovery and load path rewriting - #344
Conversation
🦋 Changeset detectedLatest commit: f6b436e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 5
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f6b436e
☁️ Nx Cloud last updated this comment at |
commit: |
Merging this PR will not alter performance
|
🎯 Changes
rewriteSkillLoadPaths, skipexistsSync(join(projectRoot, 'node_modules', packageName))whenpackageRootis already that top-levelnode_modules/<package>directory.createPackageKindResolver, return() => 'npm'immediately whenworkspacePackageKeys.size === 0instead of callinggetFsIdentity(packageRoot)on every package.tryRegister, check raw-path deduplication (attemptedRawDirs) andopts.exists(join(dirPath, 'skills'))beforeshouldAttemptPackageRoot(dirPath)solstatSyncandrealpathSyncare not run onnode_modulespackages that do not ship askills/directory.benchmarks/intent, Vitest 4.1.11 on Windows Node)main(cb45f14) mean (rme)f6b436e) mean (rme)list.bench.ts(scans a consumer workspace)load.bench.ts(loads a direct dependency skill)✅ Checklist
pnpm run test:pr(runpnpm build:allfirst).🚀 Release Impact