Repository navigation
perf: share the filesystem cache across validate and repair - #340
Conversation
🦋 Changeset detectedLatest commit: 505b3d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 4
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 505b3d0
☁️ Nx Cloud last updated this comment at |
commit: |
Merging this PR will not alter performance
|
🎯 Changes
runValidateCommandInternalandrunRepairCommandpreviously destructuredconst { findSkillFiles } = createIntentFsCache()and discarded theIntentFsCacheinstance, so everyresolveProjectContextandfindWorkspacePackagescall created a fresh cache or ran uncached, andcollectPackagingWarningsand thepackageNamelookup beforecheckSkillBlocksre-read and parsedpackage.jsonfrom disk.fsCacheinrunValidateCommandInternalandrunRepairCommandand pass it throughresolveProjectContext,collectDefaultSkillsDirs,findWorkspacePackages,collectPackagingWarnings,repairRoot, and thepackageNamelookup beforecheckSkillBlocks.intent validatenow readspackage.jsononce instead of 4–5 times.benchmarks/intent/validate.bench.ts, Vitest 4.1.11 on Windows Node)main(79d7cc2) mean (rme)505b3d0) mean (rme)checks a shipped skills tree✅ Checklist
pnpm run test:pr(runpnpm build:allfirst).🚀 Release Impact
Summary by CodeRabbit