Repository navigation
Conversation
Add the classloader container properties to the component loading page, a JVM properties reference page, and fix the checkpoint property name. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Scope & Design Review — QTDI-2853 (round 1: APPROVED)No Blocker or Major findings. 2 Minor (non-blocking):
Signed: Claude Sonnet 5.5 |
Code Review / Compliance — QTDI-2853Reviewed 4 files (docs only): nav.adoc, component-checkpoint.adoc, component-loading.adoc, ref-jvm-properties.adoc. Checks: valid xrefs; property names, defaults and match semantics verified against ComponentManager, MavenRepositoryDefaultResolver, Mode, ConfigurableClassLoader, EnhancedObjectInputStream, TomcatSetup; consistent terminology; no Java/test changes; commit message follows
Info: Antora build not run locally; rely on CI. Signed: Claude Sonnet 5.5 |
|
There was a problem hiding this comment.
🟡 Changes recommended
Two documentation inaccuracies or omissions remain in the JVM properties reference page.
1 open issue
What changed in this PR
This documentation-only pull request expands Antora documentation for Component Kit JVM properties, classloader configuration, runtime settings, and checkpoint activation.
Changes:
- Documents classloader extension properties, matching semantics, defaults, and isolation considerations.
- Adds and links a JVM properties reference page.
- Corrects
talend.checkpoint.enabletotalend.checkpoint.enabled. - Adds the Vault readiness configuration to generated server documentation.
| File | Description | Review comments |
|---|---|---|
documentation/src/main/antora/modules/ROOT/pages/ref-jvm-properties.adoc |
Adds the JVM properties reference tables. | Nit (4 votes): Document that talend.component.manager.m2.settings requires talend.component.manager.user.m2.fallback to be enabled, including the related settings/environment discovery behavior. Nit (1 vote): Describe the true-value behavior for talend.checkpoint.enabled rather than attributing it specifically to Boolean.getBoolean. |
documentation/src/main/antora/modules/ROOT/pages/component-loading.adoc |
Documents classloader JVM properties, matching behavior, examples, and isolation considerations. | No review comments. |
documentation/src/main/antora/modules/ROOT/pages/component-checkpoint.adoc |
Corrects the checkpoint property name and example. | No review comments. |
documentation/src/main/antora/modules/ROOT/pages/_partials/generated_server-configuration.adoc |
Documents the Vault readiness configuration property. | No review comments. |
documentation/src/main/antora/modules/ROOT/nav.adoc |
Adds the JVM properties page to the reference navigation. | No review comments. |
Review effort: Lite
| | `talend.component.manager.m2.settings` | path | _none_ | Maven `settings.xml` read to find the `localRepository` when `talend.component.manager.m2.repository` is not set. | ||
| | `talend.component.manager.user.m2.fallback` | boolean | `false` | When no repository was found by the other mechanisms, falls back to `${user.home}/.m2/repository`. |

0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (62.30% Estimated after merge)
Requirements
Why this PR is needed?
The classloader JVM properties (
talend.component.manager.classloader.container.classesAndPackagesand...parentResources) and the other component-manager runtime properties were not documented. The checkpoint page also used the wrong property name. Jira: QTDI-2853.What does this PR adds (design/code thoughts)?
Docs only (Antora,
documentationmodule); property names, defaults and match semantics were checked against the code (ComponentManager,MavenRepositoryDefaultResolver,Mode,ConfigurableClassLoader,EnhancedObjectInputStream).component-loading.adoc: new "Classloader JVM properties" section (prefix vs contains matching, comma-separated, additive to built-in defaults,-Dexample, isolation caution).ref-jvm-properties.adoc(new): reference of the other runtime properties (purpose, default, type), linked from the reference nav.nav.adoc: add the new page.component-checkpoint.adoc:talend.checkpoint.enable→talend.checkpoint.enabled(matchesComponentManager/InputImpl).Antora build was not run locally; CI docs build will confirm.
AI contribution metrics
100%(80/80 changed lines)100%~15%(estimated word-level diff, 1 revision)AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code