Repository navigation
fix: complete manifest readiness, timed batching and shared-memory shutdown - #674
Merged
Merged
Conversation
26 of 33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release validation exposed three correctness gaps: dynamic-module tests could request a proxy before the remote manifest arrived, a delayed send-pump wake could flush a timed batch early, and Windows shared-memory shutdown could exhaust its cleanup budget while disposing a mapped view.
The changes wait for manifest readiness, recheck the queue and original flush deadline after a wake, and close transient mapping views without the accessor’s unnecessary explicit file flush. The Windows failure-dump helper now captures the failing process with the installed diagnostic tool and waits for capture before final cleanup.
Validation:
The change preserves the existing cleanup budget and still joins and releases owned resources. It adds no per-RPC state or allocation. Idle send-pump BenchmarkDotNet results remain 2.589 → 2.579 µs and 536 B/op; the manual-clock timed-batch measurement was inconclusive and is not claimed as a pass. The final-main package ABA comparison remains a separate prerequisite for publication.