Repository navigation
feat(client): export redacted support snapshots - #645
Merged
Merged
Conversation
SunSi12138
marked this pull request as ready for review
September 9, 2026 18:54
SunSi12138
commented
Sep 10, 2026
SunSi12138
left a comment
Owner
Author
There was a problem hiding this comment.
整体方向和 redaction/有界 JSON 设计是合理的,exact-head CI 也已通过。当前有两个 cluster diagnostics 语义缺口值得在合并前处理:cluster 拓扑只从 ready connection 反推,导致 connecting/retiring/资源统计丢失;以及 last connection failure 目前没有接入 static/dynamic cluster 的真实失败路径。两点都直接影响 #575 的核心排障价值,见 inline。
26 of 33 tasks
Owner
Author
|
Final re-review: both substantive cluster-diagnostics findings are resolved on exact head
No new correctness/redaction/boundedness blocker was found. #645 has been squash-merged into |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #575
Summary
SharpLink.ClientSystem.Text.Jsonsource generation for both pretty and compact export; no reflection-based JSON serialization or runtime enum converter generationdoc/troubleshooting.mdAcceptance coverage
Validation
Final head:
017cc8da5ddca63416016803aa939d2e17dbe7c4The first PR Fast attempt on the final head hit one unrelated existing timed-unary emission test timeout; the same-head PR Quick Unit run and the PR Fast rerun both passed all 1,669 tests.