Repository navigation
Add label position setting to Get Request - #10
Open
simon-t-grimm wants to merge 1 commit into
Open
simon-t-grimm wants to merge 1 commit into
simon-t-grimm wants to merge 1 commit into
Conversation
The result was always written to the center label. Since label control became per position, an action that only controls the top or bottom label had its result dropped silently, so a key could not show two values from two Get Request actions. Add a "Label Position" setting that defaults to center, keeping existing setups unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MeFzzhJmCaCidJiCC7cEcS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Get Request always writes its result to the center label. Since label control became per position, an action that controls only the top or bottom label has its result dropped silently, because
set_labelreturns early whenhas_label_controlis false.This makes it impossible to show two values on one key, for example temperature in the center and humidity at the bottom from two Get Request actions.
Change
Add a "Label Position" setting (Top, Center, Bottom) to Get Request.
Testing
Tested against StreamController 1.5.0-beta.16 (Flatpak) with a Stream Deck + attached:
main.py. The base action class was stubbed, with its label control check reproduced.🤖 Generated with Claude Code