Skip to content

Add label position setting to Get Request - #10

Open
simon-t-grimm wants to merge 1 commit into
StreamController:mainfrom
simon-t-grimm:get-request-label-position
Open

simon-t-grimm wants to merge 1 commit into
StreamController:mainfrom
simon-t-grimm:get-request-label-position

Conversation

@simon-t-grimm

@simon-t-grimm simon-t-grimm commented Nov 4, 2026 •

Copy link
Copy Markdown

Problem

Get Request always writes its result to the center label. Since label control became per position, an action that controls only the top or bottom label has its result dropped silently, because set_label returns early when has_label_control is false.

This makes it impossible to show two values on one key, for example temperature in the center and humidity at the bottom from two Get Request actions.

Change

Add a "Label Position" setting (Top, Center, Bottom) to Get Request.

  • The default is center, so existing setups keep working without changes.
  • Unknown stored values fall back to center.
  • Changing the position moves the current value, so no stale copy stays behind.
  • The action still needs label control for the chosen position. The row subtitle says so, because a missing permission fails silently.

Testing

Tested against StreamController 1.5.0-beta.16 (Flatpak) with a Stream Deck + attached:

  • Ran a scripted test in the Flatpak runtime with real Gtk and Adw widgets and the real main.py. The base action class was stubbed, with its label control check reproduced.
  • It covers the default position, the fallback for invalid values, two actions on one key, moving the value when the position changes, and that opening the config does not write settings.
  • Installed the plugin locally and restarted the app. The page loaded with no plugin errors in the log.
  • The rendered labels on the device itself have not been checked yet.

🤖 Generated with Claude Code

The result was always written to the center label. Since label control
became per position, an action that only controls the top or bottom
label had its result dropped silently, so a key could not show two
values from two Get Request actions.

Add a "Label Position" setting that defaults to center, keeping existing
setups unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MeFzzhJmCaCidJiCC7cEcS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant