Angular event not work as documented #319

Activity

1. yohankoehler commented on Mar 25, 2015

   

   yohankoehler

   on Mar 25, 2015

   More actions

   I've got the same issue, you can fix it by adding keys in the object in the _emitEvent() function in ng-sortable.js.

   So the old one (line 80 from ng-sortable.js)

   options[name] && options[name]({
     model: item,
     models: source && source.items(),
     oldIndex: evt.oldIndex,
     newIndex: evt.newIndex
   });
   

   and the new one

   options[name] && options[name]({
     model: item,
     models: source && source.items(),
     oldIndex: evt.oldIndex,
     newIndex: evt.newIndex,
     from : evt.from,
     item : evt.item
   });
   

   .from works great but it seems tha .item is a copy of the item and not the original one
2. yohankoehler

   added a commit that references this issue on Mar 25, 2015

   Fix SortableJS#319, add 'from' and 'item' properties.

   ...

   This issue will close once commit 9e77780 is merged into the 'master' branch.

   9e77780
3. RubaXa commented on Mar 25, 2015

   

   RubaXa

   on Mar 25, 2015

   Collaborator

   More actions

   Because: https://github.com/RubaXa/Sortable/blob/master/ng-sortable.js#L18-L24
4. RubaXa commented on Mar 25, 2015

   

   RubaXa

   on Mar 25, 2015

   Collaborator

   More actions

   @yohankoehler Working with DOM elements is not Angular way.
5. yohankoehler commented on Mar 25, 2015

   

   yohankoehler

   on Mar 25, 2015

   More actions

   @RubaXa You are in a directive.
6. RubaXa commented on Mar 25, 2015

   

   RubaXa

   on Mar 25, 2015

   Collaborator

   More actions

   @yohankoehler So what? Your commit are forwarding DOM elements from directive to outside.
7. yohankoehler commented on Mar 25, 2015

   

   yohankoehler

   on Mar 25, 2015

   More actions

   @RubaXa my bad, sorry please forget this commit !!!.

   @Raiseupcreativity So I guess you will have to deal with the onRemove event to retrieve the model that the item is comming from.
8. RubaXa commented on Mar 25, 2015

   

   RubaXa

   on Mar 25, 2015

   Collaborator

   More actions

   @yohankoehler Already forgotten 🙈
9. simobasso commented on Mar 26, 2015

   

   simobasso

   on Mar 26, 2015

   Author

   More actions

   yes but I've need access on drag-over target, but i've made another directive for that....
10. simobasso

    closed this as completedon Mar 26, 2015